switching from .compiled.js to .umd.js #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwcz
reviewed
Aug 3, 2018
| cpthemeTemplate.setAttribute("id", templateId); | ||
| cpthemeTemplate.innerHTML = `<style id="${templateId}-style">:root { | ||
Contributor
There was a problem hiding this comment.
Any idea why this file was changed? I'm assuming prettier, but prettier should have formatted it when Mark committed it.
mwcz
approved these changes
Aug 3, 2018
Contributor
mwcz
left a comment
mwcz
left a comment
There was a problem hiding this comment.
Lazy Garfield Turns Murderous
mwcz
reviewed
Aug 7, 2018
| return del(["./*.umd.*"]); | ||
| }); | ||
|
|
||
| gulp.task("compile", () => { |
Contributor
There was a problem hiding this comment.
@kylebuch8 Missed this during the review, but line 21 should have compiled changed to umd I think?
starryeyez024
added a commit
that referenced
this pull request
Aug 15, 2018
* rh-cta: Removing call to breakpoint-sass that broke npm run build. Works now. Fixing some var assignment bugs in RH-CTA test pr and add cta type select box (#102) adding the ability to set the rh-type attribute (#101) switching from .compiled.js to .umd.js (#100) Adding licenses (#99) Moving CP Theme to a new themes dir (#94) # Conflicts: # elements/rh-cta/demo/index.html # elements/rh-cta/rh-cta.compiled.js # elements/rh-cta/rh-cta.js # elements/rh-cta/src/rh-cta.scss
14 tasks
15 tasks
37 tasks
This was referenced Sep 3, 2020
17 tasks
This was referenced Oct 1, 2020
9 tasks
16 tasks
18 tasks
18 tasks
16 tasks
Closed
18 tasks
18 tasks
This was referenced Feb 2, 2022
Closed
18 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53