Skip to content

Conversation

@castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Aug 3, 2021

Component updates: pfe-accordion

Regression in pfe-accordion rendering slotted content in the header region.

Screen Shot 2021-08-03 at 5 10 11 PM

URL: https://patternflyelements.org/components/content-set/

Testing instructions

  • Visit demo
    1. Validate that all accordion headers render with their text and not "undefined"
  • Visit demo
    1. Resize one of the panels rendering as a tabset
    2. Validate that all accordion headers it uses now render with their text and not "undefined"

Browser requirements

Your component should work in all of the following environments:

  • Latest Firefox (on Mac OS)
  • Latest Chrome (on Mac OS)
  • Latest Safari

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated (required for fix and feat changes).

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label Aug 3, 2021
@netlify
Copy link

netlify bot commented Aug 3, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: a8fbafc

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/610c303c27748500081dea5b

😎 Browse the preview: https://deploy-preview-1742--patternfly-elements.netlify.app

@github-actions github-actions bot added the AT passed Automated testing has passed label Aug 3, 2021
@castastrophe castastrophe added the next release PRs that need to merge before the next release goes out label Aug 4, 2021
@castastrophe castastrophe requested a review from kylebuch8 August 4, 2021 16:58
Copy link
Contributor

@heyMP heyMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@heyMP heyMP merged commit 3d3c4f1 into master Aug 6, 2021
@heyMP heyMP deleted the fix-content-set-accordion-headers branch August 6, 2021 17:56
@heyMP heyMP removed the next release PRs that need to merge before the next release goes out label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants