Skip to content

fix: Issue with slotted content rendering in pfe-accordion-header #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
heyMP merged 2 commits into from
Aug 6, 2021
Merged

fix: Issue with slotted content rendering in pfe-accordion-header #1742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcf91bc
Fix content-set + accordion bug
castastrophe Aug 3, 2021
a8fbafc
Merge branch 'master' into fix-content-set-accordion-headers
castastrophe Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG-1.x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

- [](https://github.com/patternfly/patternfly-elements/commit/) fix: pfe-autocomplete update aria-selected attribute
- [d3ea7fa](https://github.com/patternfly/patternfly-elements/commit/d3ea7facb0c36b7f3e20e2568bdc4bf2e5a5a852) feat: Graceful failure for component registry
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: container sass placeholder using incorrect variable for spacing (#1522)
- [099dc3e](https://github.com/patternfly/patternfly-elements/commit/099dc3e2d3ce732a32ecde0644f5c03ec1e8dd9c) fix: Accordion alignment with latest design kit
- [5f88c39](https://github.com/patternfly/patternfly-elements/commit/5f88c3963f8a6c13a9aeba6e9f664678453d46ce) fix: Jump links parseInt for IE11
- [43a904e](https://github.com/patternfly/patternfly-elements/commit/43a904e2ce4f2ef7182f803bf35ade463e7c2f1d) fix: container sass placeholder using incorrect variable for spacing (#1522)
- [](https://github.com/patternfly/patternfly-elements/commit/) fix: accordion rendering slotted content in the header

# 1.10.1 (2021-07-12)

Expand Down
6 changes: 4 additions & 2 deletions elements/pfe-accordion/src/pfe-accordion-header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,8 +196,10 @@ class PfeAccordionHeader extends PFElement {
// Capture it's assigned nodes for validation
let slotted = node.assignedNodes();
// If slotted elements were found, add it to the nodeList
if (slotted && slotted.length > 0) nodes[idx] = slotted;
else {
if (slotted && slotted.length > 0) {
// Remove the slot from the set, add the slotted content
nodes.splice(idx, 1, ...slotted);
} else {
// If no content exists in the slot, check for default content in the slot template
const defaults = node.children;
if (defaults && defaults.length > 0) nodes[idx] = defaults[0];
Expand Down