Skip to content

Conversation

@wesruv
Copy link
Contributor

@wesruv wesruv commented Oct 13, 2021

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

Testing instructions

Ideally this is tested in iOS 15 Safari

If not, put a breakpoint in the _setBreakpoint method after the if statement to make sure the code only fires on width changes.

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label Oct 13, 2021
@wesruv wesruv changed the title 1798: Fixing primary-detail resize listener so it only runs with widt… 1798: Fixing primary-detail resize listener so it only runs with width changes Oct 13, 2021
@wesruv wesruv added fix priority: high Severity level: 1 ready: code review Ready for code review! labels Oct 13, 2021
@github-actions github-actions bot added the AT passed Automated testing has passed label Oct 13, 2021
@wesruv wesruv changed the title 1798: Fixing primary-detail resize listener so it only runs with width changes fix: Fixing primary-detail resize listener so it only runs with width changes Oct 13, 2021
@netlify
Copy link

netlify bot commented Oct 13, 2021

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: b07a4f9

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/61672c5f06201d00087c5286

😎 Browse the preview: https://deploy-preview-1799--patternfly-elements.netlify.app

@wesruv wesruv changed the title fix: Fixing primary-detail resize listener so it only runs with width changes fix: Update primary-detail resize listener so it only runs with width changes Oct 13, 2021
@wesruv wesruv force-pushed the 1798-fix-primary-detail-resize-listener branch from 0658f2c to b07a4f9 Compare October 13, 2021 18:58
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loquacious Gentleman, Too Much!!!

@kylebuch8 kylebuch8 merged commit 96afdf7 into master Oct 14, 2021
@kylebuch8 kylebuch8 deleted the 1798-fix-primary-detail-resize-listener branch October 14, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed fix functionality Functionality, typically pertaining to the JavaScript. priority: high Severity level: 1 ready: code review Ready for code review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants