Skip to content

feat: adds custom event for clear search event, adds an aria label for search button (when applicable), and resolves dupe "x" with input[type="search"] #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Djfaucette merged 13 commits into from
Oct 29, 2021
Merged

feat: adds custom event for clear search event, adds an aria label for search button (when applicable), and resolves dupe "x" with input[type="search"] #1796

Djfaucette merged 13 commits into from
Oct 29, 2021

Conversation

@Djfaucette
Copy link
Contributor

@Djfaucette Djfaucette commented Oct 12, 2021

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

Testing instructions

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label Oct 12, 2021
@netlify
Copy link

netlify bot commented Oct 12, 2021 •
edited
Loading

✔️ Deploy Preview for patternfly-elements ready!

🔨 Explore the source changes: a8d93b7

🔍 Inspect the deploy log: https://app.netlify.com/sites/patternfly-elements/deploys/617c1ac616e7ab000756a20b

😎 Browse the preview: https://deploy-preview-1796--patternfly-elements.netlify.app

@github-actions github-actions bot added the AT passed Automated testing has passed label Oct 12, 2021
@github-actions github-actions bot added styles An issue or PR pertaining only to CSS/Sass tests Related to testing labels Oct 26, 2021
@Djfaucette Djfaucette changed the title WIP: adds custom event for clear search event and adds an aria label for search button (when applicable) feat: adds custom event for clear search event, adds an aria label for search button (when applicable), and resolves dupe "x" with input[type="search"] Oct 27, 2021
@Djfaucette Djfaucette changed the title feat: adds custom event for clear search event, adds an aria label for search button (when applicable), and resolves dupe "x" with input[type="search"] WIP: feat: adds custom event for clear search event, adds an aria label for search button (when applicable), and resolves dupe "x" with input[type="search"] Oct 28, 2021
@Djfaucette Djfaucette changed the title WIP: feat: adds custom event for clear search event, adds an aria label for search button (when applicable), and resolves dupe "x" with input[type="search"] feat: adds custom event for clear search event, adds an aria label for search button (when applicable), and resolves dupe "x" with input[type="search"] Oct 28, 2021
@bennypowers
Copy link
Member

bennypowers commented Oct 28, 2021

cc'ing myself so I can rebase #1804 when this lands

@github-actions github-actions bot added demo Updating demo pages docs Documentation updates labels Oct 29, 2021
@Djfaucette Djfaucette enabled auto-merge October 29, 2021 14:17
kylebuch8
kylebuch8 approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@kylebuch8 kylebuch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucky Goblins Treat Marshmallows 🎃

@Djfaucette Djfaucette merged commit f33ba4a into master Oct 29, 2021
@Djfaucette Djfaucette deleted the autosomepleat branch October 29, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kylebuch8 kylebuch8 kylebuch8 approved these changes

Assignees

No one assigned

Labels

AT passed Automated testing has passed demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. ready to merge styles An issue or PR pertaining only to CSS/Sass tests Related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Djfaucette @bennypowers @kylebuch8