Skip to content

Conversation

@wesruv
Copy link
Contributor

@wesruv wesruv commented Sep 3, 2020

Made search dropdown a wrapper div instead of the slot, so aria-hidden would never get applied to the slot


name: Default template
about: Generic template
labels: "feature, needs: AT updates, needs: changelog, needs: branch testing, priority: low"

Component name

Related issue

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

Link to discovery documentation (should contain all the planning and requirements for this work):

Testing instructions

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 68 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Repository compiles and tests pass.
  • Changelog updated (not needed for documentation updates).
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

Made search dropdown a wrapper div instead of the slot, so aria-hidden would never get applied to the slot
@wesruv wesruv merged commit 0e2154c into patternfly:CPFED-3689-new-navigation-epic Sep 3, 2020
@wesruv wesruv deleted the CPFED-3846-search-form-intermittently-invisible branch September 3, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant