Add button variant to pfe-autocomplete #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version bumps from release/v1.0.0-prerelease.55
* inital stab at framework testing * more react and vue tests * tests for cta, datetime, dropdown, health-index, icon, icon-panel, jump-links, markdown, modal, navigation, number, page-status, and progress-indicator * adding jump-links tests * framework tests for select, tabs, and toast * fixing pfe-content-set react test * fixing datetime tests in react React seems to be a bit weird about attribute order. Moving the datetime attribute to the end seems to fix it. * updating pfe-dropdown test to skip a single test for Vue and React * skip one pfe-health-index test in React * removing react tests and commenting out a Vue test * adding a pfe-jump-links test back for Vue * removing the failing React tests for pfe-navigation * package-lock updates * Revert "package-lock updates" This reverts commit 29cd01a. * updating package-lock.json * using the root div instead of document.body for React * updating pfe-autocomplete tests
* first pass at visual regression testing * updating package-lock.json * updating the baseline * adding http-server for local testing I couldn't figure out a way to kill the npm start process in the onComplete callback for web driver. Adding http-server, starting it in onPrepare, storing the process as a variable, and then killing it in the onComplete callback works well. * working on creating dynamic tests * adding a test for pfe-accordion * updating travis file to run just e2e second * updating pfe-accordion baseline images * new baseline images, more tests, and updated configuration * pfe-collapse, pfe-content-set, pfe-cta, pfe-datetime tests * more tests and baseline images * using local versions of webcomponentsjs and require Trying to cut down on external dependencies for testing * moving webcomponentsjs and requirejs to dependencies * making webcomponentsjs and requirejs devDependencies again * copying webcomponentsjs and requirejs in the build step * using webcomponentsjs and requirejs from the examples directory * using local images instead of images from the internet * updating spandx config to the root doesn't point to just node_modules * increasing e2e test timeout to 30 seconds and increasing the maxInstances to 7 * updating the location of the webcomponent polyfills and require * creating a simplified e2e demo page for pfe-icon * updating and creating e2e tests * updated and new baseline images * updating the location of the web component polyfills and require.js in the generator * adding more wait time in the autocomplete e2e test * updating demo page polyfills and require and updating baseline images * trying a lower number of max instances * more baseline updates * updating pfe-health-index IE11 baseline * updating pfe-cta IE11 baseline * adding 500x500 kitten * baseline updates and test adjustments * package-lock updates * increase the tolerance in the pfe-toast test
* feat: pfe-button component First pass at creating a button. * pfe-button readme, story, tests, and JS updates * adding code comments * first attempt at styling * Update elements/pfe-button/src/pfe-button.json Co-authored-by: [ Cassondra ] <[email protected]> * using denylistAttributes instead of blackListedAttributes * adding a React demo page * removing discovery and changelog documents * style: 💄 add button line-height * style: 💄 add button font-family * refactor: 🎨 interpolate variables expressions * refactor: 🎨 interpolate variables expressions * feat: 💄 add additional border vars * refactor: 🎨 interpolate, use new border vars, & cleanup * style: 💄 add correct bg color for control disabled state * refactor: 🎨 cleanup * fix: 🐛 add submit and button types to demo; tweak input style * feat: ✨ log click events in storybook * feat: use pf theme colors * using the pfe-var(line-height) variable * updating text in pfe-button test * Update pfe-button.scss Stylesheet suggestions; simplified the interpolation and reduced unnecessary selectors * Update pfe-button.scss Moved after to a region * fix: add custom click event to schema * fix: hover property overrides for variants * Bring in the extra PF colors we need to support the form styles * adding Wes and Ivana as contributors * updating pfe-page-status test because critical color has changed * adding react, vue, and e2e tests and updating baselines * adding button test index file Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: Ivana Rodriguez <[email protected]> Co-authored-by: Ivana Rodriguez <[email protected]> Co-authored-by: [ Cassondra ] <[email protected]>
* feat: Remove build from postinstall * feat: Add changelog * feat: Update readme to clarify change
* fix: fix issue in new scripts * fix: Remove label requirement for manual run script * fix: Revert version of plugin * fix: add env variables * fix: move env definition? * fix: trying to get the key to work for browserstack * fix: use a different package * fix: Move commands out of browserstack script * fix: rename env variables * fix: Update both regression scripts * fix: add support for run e2e label; remove duplication of script * fix: Don't need the browserstack keys anymore in automerge * fix: allow manual running of script * fix: remove dependency
…exts (#1021) * adjust spacing above vertical tabs, and colors of dark/saturated tab highlights * updates to border * Resolve border issues * Fixes for variables * Fix demo page CSS * remove commented out code * remove local debug mixins * Update elements/pfe-tabs/src/pfe-tab.scss Co-authored-by: [ Cassondra ] <[email protected]> * Tidy * Add const with colors * Remove test colors * changelog * Move TOC over to right side, and other demo CSS adjustments to get more tabs on the page for the visual regression test. * updating pfe-tabs vrt baseline images Co-authored-by: [ Cassondra ] <[email protected]> Co-authored-by: Kyle Buchanan <[email protected]>
version bumps from release/v1.0.0-prerelease.56
* dev script add start; start support specific component build * More granular listing logic in spandx
* feat Add a command line open PR prompt * feat Put string master in quotes * feat Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Default template
about: Generic template
labels: "feature, needs: AT updates, needs: changelog, needs: branch testing, priority: low"
Component name
Related issue
Preview
Link(s) to demo page(s) where this element can be viewed:
What has changed and why
Link to discovery documentation (should contain all the planning and requirements for this work):
Testing instructions
Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable.
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!