Skip to content

pfe-tab design tweaks & support for local vars in non-light contexts #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kylebuch8 merged 19 commits into from
Aug 26, 2020
Merged

pfe-tab design tweaks & support for local vars in non-light contexts #1021

kylebuch8 merged 19 commits into from
Aug 26, 2020

Conversation

@starryeyez024
Copy link
Member

@starryeyez024 starryeyez024 commented Jul 31, 2020 •
edited
Loading

pfe-tabs

Color & spacing tweaks

Related issue

Preview

What has changed and why

  • adjust spacing above vertical tabs
  • colors of dark/saturated tab highlights

Testing instructions

  1. Review mockups in issue, compare with test page
    BLOCKED waiting on saturated mockups

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Repository compiles and tests pass.
  • Changelog updated (not needed for documentation updates).
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

@starryeyez024 starryeyez024 added the design system Updates or issues to align components to the Red Hat Design System. label Jul 31, 2020
@castastrophe castastrophe added the styles An issue or PR pertaining only to CSS/Sass label Jul 31, 2020
@starryeyez024 starryeyez024 added needs design specs work in progress POC / Not ready for review on hold wait to merge labels Jul 31, 2020
@starryeyez024 starryeyez024 linked an issue Jul 31, 2020 that may be closed by this pull request
pfe-tabs changes #1016
Closed
@castastrophe castastrophe marked this pull request as draft August 13, 2020 14:01
@castastrophe castastrophe added the demo Updating demo pages label Aug 17, 2020
@starryeyez024 starryeyez024 marked this pull request as ready for review August 18, 2020 13:08
@starryeyez024 starryeyez024 changed the title pfe-tab design tweaks pfe-tab design tweaks & support for local vars in non-light contexts Aug 18, 2020
castastrophe
castastrophe suggested changes Aug 24, 2020
View reviewed changes
@castastrophe castastrophe added ready: branch testing Test the component from a user-perspective. Try to break it! ready: browser testing Test the component in the supported browser environments. priority: medium Severity level: 2 size: md Sizing label; indicates a moderate difficulty level or amount of work and removed needs design specs on hold wait to merge work in progress POC / Not ready for review labels Aug 24, 2020
castastrophe
castastrophe reviewed Aug 24, 2020
View reviewed changes
castastrophe
castastrophe reviewed Aug 24, 2020
View reviewed changes
@castastrophe castastrophe added the needs changelog Be sure to update the Changelog before merging. label Aug 24, 2020
castastrophe
castastrophe approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@castastrophe castastrophe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few #dust notes but could be merged after testing.

@castastrophe castastrophe added the tests Related to testing label Aug 25, 2020
castastrophe
castastrophe reviewed Aug 26, 2020
View reviewed changes
elements/pfe-tabs/test/pfe-tabs_test.js Outdated
/* @TODO: Add focus-state tests to validate against document.activeElement */

// Themes and their expected hex values
const background_colors = {
Copy link
Contributor

@castastrophe castastrophe Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are covered now by visual regression testing (they snapshot the demo pages) so as long as this appears on the demo page, the colors are being validated.

@kylebuch8 kylebuch8 merged commit 2462e69 into master Aug 26, 2020
@kylebuch8 kylebuch8 deleted the pfe-tabs-tweaks branch August 26, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@castastrophe castastrophe castastrophe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

demo Updating demo pages design system Updates or issues to align components to the Red Hat Design System. needs changelog Be sure to update the Changelog before merging. priority: medium Severity level: 2 ready: branch testing Test the component from a user-perspective. Try to break it! ready: browser testing Test the component in the supported browser environments. size: md Sizing label; indicates a moderate difficulty level or amount of work styles An issue or PR pertaining only to CSS/Sass tests Related to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pfe-tabs changes

4 participants

@starryeyez024 @castastrophe @kylebuch8