feat: Remove build from postinstall #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
added
feature
kylebuch8
approved these changes
Aug 24, 2020
Contributor
kylebuch8
left a comment
kylebuch8
left a comment
There was a problem hiding this comment.
Love Greasy Tomato Messes 🍅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build is run after
npm installbut our watch and test commands all include the build as well. This makes the post-install step duplicative and no longer needed. Remove it from post-install will be more efficient.Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable.
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!