Skip to content

chore: extend prettier line length 120 #967 #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
castastrophe merged 3 commits into from
Sep 11, 2020
Merged

chore: extend prettier line length 120 #967 #1092

castastrophe merged 3 commits into from
Sep 11, 2020

Conversation

@wesruv
Copy link
Contributor

@wesruv wesruv commented Sep 10, 2020 •
edited by castastrophe
Loading

PR was previously: #1081

Related issue

What has changed and why

Developer experience, line length was set to 80 (the default) which felt small (to me)

Ready-for-merge Checklist

Check off items as they are completed. Feel free to delete items if they are not applicable.

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Browser testing passed (regression testing only).
  • Repository compiles and tests pass.
  • Changelog updated (not needed for documentation updates).
  • Documentation (README.md, WHY.md, etc.) updated or added.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@wesruv wesruv mentioned this pull request Sep 10, 2020
Closed
5 tasks
@castastrophe castastrophe added demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. labels Sep 10, 2020
@castastrophe castastrophe changed the title 967 extend prettier line length 120 chore: extend prettier line length 120 #967 Sep 11, 2020
@castastrophe castastrophe added ready: branch testing Test the component from a user-perspective. Try to break it! needs changelog Be sure to update the Changelog before merging. priority: low Severity level: 3 and removed needs changelog Be sure to update the Changelog before merging. labels Sep 11, 2020
@castastrophe
Copy link
Contributor

castastrophe commented Sep 11, 2020

Gorgeous! I dig it. I pulled down the branch and everything looks good. I pushed up the index file which has line number updates for the todo comments. I'll kick off the visual regression tests!

@castastrophe castastrophe added ready to merge and removed ready: branch testing Test the component from a user-perspective. Try to break it! labels Sep 11, 2020
@castastrophe castastrophe merged commit 04c9d77 into master Sep 11, 2020
@castastrophe castastrophe deleted the 967-extend-prettier-line-length-120 branch September 11, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@castastrophe castastrophe castastrophe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@castastrophe castastrophe

Labels

demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. priority: low Severity level: 3 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wesruv @castastrophe