test: visual regression testing #885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/vrt/index.js
Outdated
| @@ -0,0 +1,13 @@ | |||
| describe("PatternFly Elements", () => { | |||
Contributor
There was a problem hiding this comment.
@kylebuch8 Can we set up time to share how webrh architects this? I think it would be good to have test files for each component.
| @@ -0,0 +1,37 @@ | |||
| const { join } = require("path"); | |||
kylebuch8
changed the title
I couldn't figure out a way to kill the npm start process in the onComplete callback for web driver. Adding http-server, starting it in onPrepare, storing the process as a variable, and then killing it in the onComplete callback works well.
Closed
Trying to cut down on external dependencies for testing
kylebuch8
changed the title
mwcz
approved these changes
Aug 19, 2020
Contributor
mwcz
left a comment
mwcz
left a comment
There was a problem hiding this comment.
Lements Gression Testing Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.