-
Notifications
You must be signed in to change notification settings - Fork 106
test: framework testing #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
test: framework testing #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp-links, markdown, modal, navigation, number, page-status, and progress-indicator
React seems to be a bit weird about attribute order. Moving the datetime attribute to the end seems to fix it.
Closed
mwcz
approved these changes
Aug 19, 2020
Contributor
mwcz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's Go To Meteor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Framework Testing
Running all of our unit tests against React and Vue.
What has changed and why
I've added Vue and React as devDependencies so we can make sure our components work in Vue and React. Figuring out how to add Angular proved to be too difficult for the MVP. We'll have to research how to add Angular in the future.
The idea for framework testing ended up being pretty simple. Each test directory now includes the normal HTML tests and we've added Vue and React tests.
I've also extracted the JavaScript from the original test files so we can reuse the JavaScript tests in the HTML, React, and Vue files.
For each component, the test folder structure should look like this (using pfe-markdown as an example).
Testing instructions
npm installnpm testMerging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!