feat(spinner): 1:1

[kylebuch8]

Related issues

• (switching from .compiled.js to .umd.js #100) Description of issue

Preview

Link(s) to demo page(s) where this element can be viewed:

• Link

What has changed and why

Testing instructions

• Test case upgraded storybook to the latest alpha release and added a command fo… #1
  1. Go here
  2. Do this
• Test case adding command for new RHElement using generator-rhelement #2
  1. Go here
  2. Do this

Browser requirements

Your component should work in all of the following environments:

• Latest 2 versions of Edge
• Internet Explorer 11 (should be useable, not pixel perfect)
• Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
• Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
• Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
• Latest 2 versions of Safari
• Android mobile device (such as the Galaxy S9)
• Apple mobile device (such as the iPhone X)
• Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

• Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
• Tests have been updated to cover these changes.
• Browser testing passed.
• Changelog updated.
• Documentation (README.md, WHY.md, etc.) updated or added.
• Link to the demo recording:
• Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

[changeset-bot]

🦋 Changeset detected

Latest commit: b5c0127

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@patternfly/pfe-spinner	Minor
@patternfly/pfe-button	Patch
@patternfly/pfe-tools	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

✅ Deploy Preview for patternfly-elements ready!

Name	Link
🔨 Latest commit	614f668
😎 Deploy Preview	https://deploy-preview-2155--patternfly-elements.netlify.app/

---

_To edit notification comments on pull requests, go to your Netlify site settings.

[bennypowers]

looks really nice. A few small nits, and some suggestions for tightening up the user-facing api and internal dom. can't wait to merge this :)

[bennypowers]

This will need a changeset

[bennypowers]

Some CSS refactoring and this should be g2g

[bennypowers]

• simplified the demo page - they're meant to be debugging tools more than documentation, so i removed the code blocks.
• refactored the css to
  • use fallbacks instead of assigning on the host
  • use aspect-ratio instead of setting width and height
  • use styleMap instead of setting style attr on the host
• refactored tests to check element's computed width in px instead of the assigned custom property

@kylebuch8 approving now, resolve the above conversation to merge, pending design approval

[bennypowers]

Good going, Kyle