feat(popover): add pf-popover #2320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3c7161c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bennypowers
reviewed
Jan 30, 2023
bennypowers
requested changes
Feb 1, 2023
Member
bennypowers
left a comment
bennypowers
left a comment
There was a problem hiding this comment.
time to merge in the main branch. Please address the comments here before merging, to make it easier on you when you merge them in.
Once main is merged and conflicts are resolved, please rename the shadow stylesheets to .css and validate their syntax (watch for comments and nesting)
github-actions
bot
added
demo
bennypowers
reviewed
Apr 19, 2023
bennypowers
requested changes
Apr 19, 2023
eyevana
commented
Apr 27, 2023
bennypowers
approved these changes
Apr 27, 2023
Contributor
Author
|
@bennypowers the demo page looks soooo much better. Thank you! 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pf-popover
Implemented Patternfly's Popover as web component.
Related issues
Preview
Link(s) to demo page(s) where this element can be viewed:
Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!