Skip to content

Conversation

@bennypowers
Copy link
Member

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

Testing instructions

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022

⚠️ No Changeset found

Latest commit: b041613

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-modal Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. AT passed Automated testing has passed labels Jan 31, 2022
@bennypowers bennypowers force-pushed the feat/pfe-tools-modal-implements-dialog branch 3 times, most recently from 63a4126 to 96a9a36 Compare January 31, 2022 17:58
@bennypowers bennypowers force-pushed the feat/pfe-tools-modal-implements-dialog branch from 96a9a36 to aca68b8 Compare January 31, 2022 18:19
@bennypowers bennypowers merged commit d706f8d into feat/pfe-tools Jan 31, 2022
@bennypowers bennypowers deleted the feat/pfe-tools-modal-implements-dialog branch January 31, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants