discuss renaming built files

[mwcz]

Proposed change:

1. rename rh-foo/rh-foo.compiled.js to rh-foo/rh-foo.es5.js
2. rename rh-foo/rh-foo.js to rh-foo/rh-foo.mjs

Reasoning:

For the first one, "es5" conveys the purpose of the file more clearly than "compiled". For the second, there are some good reasons to use the mjs file extension for ES modules.

These changes will make more clear to contributors and users what the purpose of the two built files are.

[KamiQuasi]

I think these are really appropriate changes to make. Given the import syntax rules for modules it makes sense, and doesn't add any complexity to the usage.

[mwcz]

@kylebuch8, what do you think?

[kylebuch8]

@mwcz - I'm good with changing .compiled.js to .es5.js but I'm not so sure .mjs is the way to go. Some Google searches show that other teams have tried this but have then struggled with Webpack and CommonJS.

[mwcz]

Good suggestion from Doug: .umd.js instead of .es5.js. I think I'm onboard with that.