CPFED-3754: Developer Experience improvements and documentation updates #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added .pfe-navigation__fallback-links to substite for secondary links in no-JS version Removed the need for .pfe-navigation__dropdown-wrapper in LightDOM markup, adding it in JS Removing style attribute in demo page and moving styles to pfe-navigation--lightdom.[s]css Adding has-dropdown class dynamically Reworked has-dropdown class to BEM format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .pfe-navigation__fallback-links to substite for secondary links in no-JS version
Removed the need for .pfe-navigation__dropdown-wrapper in LightDOM markup, adding it in JS
Removing style attribute in demo page and moving styles to pfe-navigation--lightdom.[s]css
Adding has-dropdown class dynamically
Reworked has-dropdown class to BEM format