Skip to content

WIP: feat(tooltip): adding pfe-tooltip #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brianferry wants to merge 15 commits into from
Closed

WIP: feat(tooltip): adding pfe-tooltip #1960

brianferry wants to merge 15 commits into from

Conversation

@brianferry
Copy link
Collaborator

@brianferry brianferry commented Mar 23, 2022 •
edited
Loading

adding to elements list, including popperjs in tooltip

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 829b9e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-tooltip Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools work in progress POC / Not ready for review AT passed Automated testing has passed labels Mar 23, 2022
@netlify
Copy link

netlify bot commented Mar 23, 2022 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 829b9e7
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/62422c2fe0526f00087217e3
😎 Deploy Preview https://deploy-preview-1960--patternfly-elements.netlify.app/blog/pfe-2-0-prerelease
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2022 •
edited
Loading

🏮 Lighthouse report for the changes in this PR:

🔴 🟢 🟢 🟠 ⚪️ https://deploy-preview-1960--patternfly-elements.netlify.app/kitchen-sink/

🔦 Lighthouse Report for https://deploy-preview-1960--patternfly-elements.netlify.app/kitchen-sink/

🔬 View Detailed results 🧾

Category Score
🔴 Performance 26
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 83

💥 Assertion Failures

Audit Result Docs
Reduce JavaScript execution time 0.01 (expected >=0.9) 📗
Background and foreground colors do not have a sufficient contrast ratio. 0 (expected >=0.9) 📗
Avoid an excessive DOM size 0.11 (expected >=0.9) 📗
First Contentful Paint 0.78 (expected >=0.9) 📗
First Meaningful Paint 0.08 (expected >=0.9) 📗
Image elements do not have [alt] attributes 0 (expected >=0.9) 📗
Largest Contentful Paint 0.05 (expected >=0.9) 📗
Minimize main-thread work 0 (expected >=0.9) 📗
Max Potential First Input Delay 0 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.03 (expected >=0.9) 📗
Reduce unused JavaScript 1 (expected <=0) 📗
Uses efficient cache policy on static assets 2 (expected <=0) 📗
Document does not have a valid rel=canonical 0 (expected >=0.9) 📗
Time to Interactive 0.15 (expected >=0.9) 📗
undefined 0.92 (expected >=1) 📗
🟢 🟢 🟢 🟢 ⚪️ Styles

🔦 Lighthouse Report for Styles

🔬 View Detailed results 🧾

Category Score
🟢 Performance 94
🟢 Accessibility 90
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Background and foreground colors do not have a sufficient contrast ratio. 0 (expected >=0.9) 📗
First Contentful Paint 0.73 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Heading elements are not in a sequentially-descending order 0 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Minify JavaScript 1 (expected <=0) 📗
undefined 0.9 (expected >=1) 📗
🟠 🟢 🟢 🟢 ⚪️ Accordion

🔦 Lighthouse Report for Accordion

🔬 View Detailed results 🧾

Category Score
🟠 Performance 67
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Reduce JavaScript execution time 0.81 (expected >=0.9) 📗
Background and foreground colors do not have a sufficient contrast ratio. 0 (expected >=0.9) 📗
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.73 (expected >=0.9) 📗
First Meaningful Paint 0.79 (expected >=0.9) 📗
Largest Contentful Paint 0.78 (expected >=0.9) 📗
Minimize main-thread work 0.7 (expected >=0.9) 📗
Max Potential First Input Delay 0 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.62 (expected >=0.9) 📗
Uses efficient cache policy on static assets 1 (expected <=0) 📗
undefined 0.97 (expected >=1) 📗
🟢 🟢 🟢 🟢 ⚪️ Autocomplete

🔦 Lighthouse Report for Autocomplete

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.71 (expected >=0.9) 📗
🟠 🟢 🟢 🟢 ⚪️ Avatar

🔦 Lighthouse Report for Avatar

🔬 View Detailed results 🧾

Category Score
🟠 Performance 86
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Largest Contentful Paint 0.68 (expected >=0.9) 📗
Serve images in next-gen formats 1 (expected <=0) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Preload Largest Contentful Paint image 0.54 (expected >=0.9) 📗
Speed Index 0.67 (expected >=0.9) 📗
Serve static assets with an efficient cache policy 1 (expected <=0) 📗
Efficiently encode images 1 (expected <=0) 📗
🟢 🟢 🟢 🟢 ⚪️ Badge

🔦 Lighthouse Report for Badge

🔬 View Detailed results 🧾

Category Score
🟢 Performance 90
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.67 (expected >=0.9) 📗
First Meaningful Paint 0.85 (expected >=0.9) 📗
Largest Contentful Paint 0.88 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.66 (expected >=0.9) 📗
Minify JavaScript 1 (expected <=0) 📗
🟠 🟢 🟢 🟢 ⚪️ Band

🔦 Lighthouse Report for Band

🔬 View Detailed results 🧾

Category Score
🟠 Performance 86
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Heading elements are not in a sequentially-descending order 0 (expected >=0.9) 📗
Largest Contentful Paint 0.88 (expected >=0.9) 📗
Max Potential First Input Delay 0.06 (expected >=0.9) 📗
Serve images in next-gen formats 1 (expected <=0) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Defer offscreen images 1 (expected <=0) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.74 (expected >=0.9) 📗
Efficiently encode images 1 (expected <=0) 📗
undefined 0.96 (expected >=1) 📗
🟢 🟢 🟢 🟢 ⚪️ Button

🔦 Lighthouse Report for Button

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Background and foreground colors do not have a sufficient contrast ratio. 0 (expected >=0.9) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.88 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.7 (expected >=0.9) 📗
undefined 0.96 (expected >=1) 📗
🟢 🟢 🟢 🟢 ⚪️ Card

🔦 Lighthouse Report for Card

🔬 View Detailed results 🧾

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 93
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Browser errors were logged to the console 0 (expected >=0.9) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Largest Contentful Paint 0.88 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Defer offscreen images 3 (expected <=0) 📗
Speed Index 0.71 (expected >=0.9) 📗
Image elements do not have explicit width and height 0 (expected >=0.9) 📗
Properly size images 2 (expected <=0) 📗
🟠 🟢 🟢 🟢 ⚪️ Clipboard

🔦 Lighthouse Report for Clipboard

🔬 View Detailed results 🧾

Category Score
🟠 Performance 88
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.67 (expected >=0.9) 📗
First Meaningful Paint 0.86 (expected >=0.9) 📗
Max Potential First Input Delay 0.49 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.69 (expected >=0.9) 📗
Uses efficient cache policy on static assets 1 (expected <=0) 📗
🟢 🟢 🟢 🟢 ⚪️ Codeblock

🔦 Lighthouse Report for Codeblock

🔬 View Detailed results 🧾

Category Score
🟢 Performance 90
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Avoid an excessive DOM size 0.53 (expected >=0.9) 📗
First Contentful Paint 0.71 (expected >=0.9) 📗
First Meaningful Paint 0.87 (expected >=0.9) 📗
Largest Contentful Paint 0.87 (expected >=0.9) 📗
Max Potential First Input Delay 0.79 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.71 (expected >=0.9) 📗
Minify JavaScript 1 (expected <=0) 📗
🟢 🟢 🟢 🟢 ⚪️ Collapse

🔦 Lighthouse Report for Collapse

🔬 View Detailed results 🧾

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.7 (expected >=0.9) 📗
First Meaningful Paint 0.87 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.69 (expected >=0.9) 📗
🟠 🟢 🟢 🟢 ⚪️ Cta

🔦 Lighthouse Report for Cta

🔬 View Detailed results 🧾

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 93
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Background and foreground colors do not have a sufficient contrast ratio. 0 (expected >=0.9) 📗
Browser errors were logged to the console 0 (expected >=0.9) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.84 (expected >=0.9) 📗
Largest Contentful Paint 0.85 (expected >=0.9) 📗
Max Potential First Input Delay 0.07 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.65 (expected >=0.9) 📗
undefined 0.96 (expected >=1) 📗
🟠 🟢 🟢 🟢 ⚪️ Datetime

🔦 Lighthouse Report for Datetime

🔬 View Detailed results 🧾

Category Score
🟠 Performance 74
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Reduce JavaScript execution time 0.82 (expected >=0.9) 📗
First Contentful Paint 0.74 (expected >=0.9) 📗
First Meaningful Paint 0.83 (expected >=0.9) 📗
Largest Contentful Paint 0.85 (expected >=0.9) 📗
Minimize main-thread work 0.78 (expected >=0.9) 📗
Max Potential First Input Delay 0.02 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.68 (expected >=0.9) 📗
🟢 🟢 🟢 🟢 ⚪️ Dropdown

🔦 Lighthouse Report for Dropdown

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.74 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.74 (expected >=0.9) 📗
🟢 🟢 🟢 🟢 ⚪️ Health Index

🔦 Lighthouse Report for Health Index

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
First Contentful Paint 0.74 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Max Potential First Input Delay 0.82 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.71 (expected >=0.9) 📗
🔴 🟢 🟠 🟢 ⚪️ Icon

🔦 Lighthouse Report for Icon

🔬 View Detailed results 🧾

Category Score
🔴 Performance 47
🟢 Accessibility 100
🟠 Best practices 87
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Reduce JavaScript execution time 0 (expected >=0.9) 📗
Avoid an excessive DOM size 0 (expected >=0.9) 📗
Browser errors were logged to the console 0 (expected >=0.9) 📗
First Contentful Paint 0.73 (expected >=0.9) 📗
Issues were logged in the Issues panel in Chrome Devtools 0 (expected >=0.9) 📗
Minimize main-thread work 0 (expected >=0.9) 📗
Max Potential First Input Delay 0 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.02 (expected >=0.9) 📗
Serve static assets with an efficient cache policy 475 (expected <=0) 📗
Time to Interactive 0.15 (expected >=0.9) 📗
🟢 🟢 🟢 🟢 ⚪️ Icon Panel

🔦 Lighthouse Report for Icon Panel

🔬 View Detailed results 🧾

Category Score
🟢 Performance 93
🟢 Accessibility 95
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.75 (expected >=0.9) 📗
Heading elements are not in a sequentially-descending order 0 (expected >=0.9) 📗
Max Potential First Input Delay 0.62 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.75 (expected >=0.9) 📗
Uses efficient cache policy on static assets 6 (expected <=0) 📗
undefined 0.95 (expected >=1) 📗
🟢 🟢 🟢 🟢 ⚪️ Jump Links

🔦 Lighthouse Report for Jump Links

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 93
🟢 SEO 91

💥 Assertion Failures

Audit Result Docs
Browser errors were logged to the console 0 (expected >=0.9) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Heading elements are not in a sequentially-descending order 0 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Defer offscreen images 1 (expected <=0) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.71 (expected >=0.9) 📗
Tap targets are not sized appropriately 0.03 (expected >=0.9) 📗
Image elements do not have explicit width and height 0 (expected >=0.9) 📗
Uses efficient cache policy on static assets 1 (expected <=0) 📗
undefined 0.96 (expected >=1) 📗
🟠 🟢 🟢 🟢 ⚪️ Label

🔦 Lighthouse Report for Label

🔬 View Detailed results 🧾

Category Score
🟠 Performance 78
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Max Potential First Input Delay 0.03 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.65 (expected >=0.9) 📗
Minify JavaScript 1 (expected <=0) 📗
Uses efficient cache policy on static assets 9 (expected <=0) 📗
🟢 🟢 🟢 🟢 ⚪️ Markdown

🔦 Lighthouse Report for Markdown

🔬 View Detailed results 🧾

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.74 (expected >=0.9) 📗
Max Potential First Input Delay 0.68 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.71 (expected >=0.9) 📗
🟢 🟢 🟢 🟢 ⚪️ Modal

🔦 Lighthouse Report for Modal

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.74 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.72 (expected >=0.9) 📗
🟢 🟢 🟢 🟢 ⚪️ Number

🔦 Lighthouse Report for Number

🔬 View Detailed results 🧾

Category Score
🟢 Performance 93
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.78 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.74 (expected >=0.9) 📗
Minify JavaScript 1 (expected <=0) 📗
🟢 🟢 🟢 🟢 ⚪️ Page Status

🔦 Lighthouse Report for Page Status

🔬 View Detailed results 🧾

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
First Contentful Paint 0.71 (expected >=0.9) 📗
First Meaningful Paint 0.88 (expected >=0.9) 📗
Largest Contentful Paint 0.89 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.71 (expected >=0.9) 📗
🟢 🟢 🟢 🟢 ⚪️ Primary Detail

🔦 Lighthouse Report for Primary Detail

🔬 View Detailed results 🧾

Category Score
🟢 Performance 93
🟢 Accessibility 92
🟢 Best practices 93
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
ARIA IDs are not unique 0 (expected >=0.9) 📗
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
Browser errors were logged to the console 0 (expected >=0.9) 📗
First Contentful Paint 0.75 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.74 (expected >=0.9) 📗
undefined 0.92 (expected >=1) 📗
🟢 🟢 🟢 🟢 ⚪️ Progress Indicator

🔦 Lighthouse Report for Progress Indicator

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Speed Index 0.71 (expected >=0.9) 📗
🟠 🟢 🟢 🟢 ⚪️ Progress Steps

🔦 Lighthouse Report for Progress Steps

🔬 View Detailed results 🧾

Category Score
🟠 Performance 80
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 98

💥 Assertion Failures

Audit Result Docs
First Contentful Paint 0.73 (expected >=0.9) 📗
First Meaningful Paint 0.85 (expected >=0.9) 📗
Largest Contentful Paint 0.87 (expected >=0.9) 📗
Max Potential First Input Delay 0.09 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.71 (expected >=0.9) 📗
Tap targets are not sized appropriately 0.83 (expected >=0.9) 📗
🟢 🟢 🟢 🟢 ⚪️ Readtime

🔦 Lighthouse Report for Readtime

🔬 View Detailed results 🧾

Category Score
🟢 Performance 91
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
First Contentful Paint 0.68 (expected >=0.9) 📗
First Meaningful Paint 0.87 (expected >=0.9) 📗
Largest Contentful Paint 0.88 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.69 (expected >=0.9) 📗
🟢 🟢 🟢 🟢 ⚪️ Select

🔦 Lighthouse Report for Select

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
First Contentful Paint 0.73 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.73 (expected >=0.9) 📗
🟠 🟢 🟢 🟢 ⚪️ Tabs

🔦 Lighthouse Report for Tabs

🔬 View Detailed results 🧾

Category Score
🟠 Performance 74
🟢 Accessibility 92
🟢 Best practices 93
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Reduce JavaScript execution time 0.88 (expected >=0.9) 📗
ARIA IDs are not unique 0 (expected >=0.9) 📗
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.72 (expected >=0.9) 📗
First Meaningful Paint 0.82 (expected >=0.9) 📗
Heading elements are not in a sequentially-descending order 0 (expected >=0.9) 📗
Issues were logged in the Issues panel in Chrome Devtools 0 (expected >=0.9) 📗
Largest Contentful Paint 0.81 (expected >=0.9) 📗
Minimize main-thread work 0.73 (expected >=0.9) 📗
Max Potential First Input Delay 0.02 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.68 (expected >=0.9) 📗
Uses efficient cache policy on static assets 3 (expected <=0) 📗
undefined 0.92 (expected >=1) 📗
🟢 🟢 🟢 🟢 ⚪️ Toast

🔦 Lighthouse Report for Toast

🔬 View Detailed results 🧾

Category Score
🟢 Performance 92
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
Remove duplicate modules in JavaScript bundles 1 (expected <=0) 📗
First Contentful Paint 0.73 (expected >=0.9) 📗
First Meaningful Paint 0.89 (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.73 (expected >=0.9) 📗
🔴 🟢 🟢 🟢 ⚪️ Tooltip

🔦 Lighthouse Report for Tooltip

🔬 View Detailed results 🧾

Category Score
🔴 Performance 0
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100

💥 Assertion Failures

Audit Result Docs
ARIA tooltip elements do not have accessible names. 0 (expected >=0.9) 📗
First Contentful Paint 0.77 (expected >=0.9) 📗
Largest Contentful Paint null (expected >=0.9) 📗
Avoid non-composited animations 0 (expected >=0.9) 📗
Preload Largest Contentful Paint image null (expected >=0.9) 📗
Eliminate render-blocking resources 1 (expected <=0) 📗
Speed Index 0.72 (expected >=0.9) 📗
undefined 0.97 (expected >=1) 📗

bennypowers
bennypowers reviewed Mar 30, 2022
View reviewed changes
elements/pfe-select/pfe-select.ts

render() {
// eslint-disable-next-line no-console
console.log(process.env.NODE_ENV);
Copy link
Member

@bennypowers bennypowers Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@brianferry brianferry closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers left review comments

Assignees

No one assigned

Labels

AT passed Automated testing has passed demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing tools Development and build tools work in progress POC / Not ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brianferry @bennypowers @zeroedin