CPFED-3790, CPFED-3791, CPFED-3792: Lots of features & bug fixes #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored open and close dropdown code Added Esc key functionality Updated variable and function names to be more consistent and easier understand Added height calculation JS to secondary link dropdowns, but isn't working yet Fixed bug where height of dropdown wasn't correct on resize Fixed animation for dropdowns Made sure 'heavy' DOM manipulation/reading isn't done all the time Added dev only console logging when heavy processes are run Moved more HTML class/id setup to JS instead of making stakeholders do it Made sure words in the top bar don't wrap Fixed jumping text Fixed bug where single column didn't have padding at smaller breakpoints
wesruv
deleted the
CPFED-3790--CPFED-3791--CPFED-3792-lots-o-features-n-bug-fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored open and close dropdown code
Added Esc key functionality
Updated variable and function names to be more consistent and easier understand
Added height calculation JS to secondary link dropdowns, but isn't working yet
Fixed bug where height of dropdown wasn't correct on resize
Fixed animation for dropdowns
Made sure 'heavy' DOM manipulation/reading isn't done all the time
Added dev only console logging when heavy processes are run
Moved more HTML class/id setup to JS instead of making stakeholders do it
Made sure words in the top bar don't wrap
Fixed jumping text
Fixed bug where single column didn't have padding at smaller breakpoints