feat: pfe-tabs style updates #948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments into feat-empty-local-variables
…rnfly/patternfly-elements into feat-empty-local-variables
# Conflicts: # CHANGELOG-prerelease.md
This was
linked to
issues
Jul 30, 2020
castastrophe
approved these changes
Jul 30, 2020
Contributor
|
It looks like the right border is too small on any tab that isn't the last child. Same issue with the vertical tabs.
|
starryeyez024
approved these changes
Jul 31, 2020
Member
starryeyez024
left a comment
starryeyez024
left a comment
There was a problem hiding this comment.
Little Guesses, Tiny Mysteries
castastrophe
removed
ready: branch testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component updates
Update pfe-tab component style to match design system specs
Preview
Link(s) to demo page(s) where this element can be viewed:
Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable.
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the [email protected] mailing list!
https://rally1.rallydev.com/#/detail/userstory/378976493960/testcases?fdp=true