Skip to content

feat(avatar): PF1:1 #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bennypowers merged 10 commits into from
Dec 8, 2022
Merged

feat(avatar): PF1:1 #2188

bennypowers merged 10 commits into from
Dec 8, 2022

Conversation

@Nouveau
Copy link
Contributor

@Nouveau Nouveau commented Oct 20, 2022 •
edited
Loading

What was done

Removed extra PFE functions
Reorganized markup to match PF
Added PF CSS variables

Testing Instructions

Load up the deploy preview for this branch
Load up PatternFly v4 Avatar
Compare and contrast
Read over the docs and see if anything's missing

Preview

Link(s) to demo page(s) where this element can be viewed:

Related issues

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the [email protected] mailing list!

@Nouveau Nouveau added work in progress POC / Not ready for review 1:1 Aligning components with PatternFly v4 labels Oct 20, 2022
@Nouveau Nouveau self-assigned this Oct 20, 2022
@changeset-bot
Copy link

changeset-bot bot commented Oct 20, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 6fe9ac9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/pfe-avatar Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing labels Oct 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022 •
edited
Loading

👕 Commitlint Problems for this PR:

🔎 found 2 errors, 0 warnings
ℹ️ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

8fdd883 - [pfe-avatar] begin removing extraneous avatar tools

  • ❌ subject may not be empty
  • ❌ type may not be empty

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

👕 Commitlint Problems for this PR:

🔎 found 2 errors, 0 warnings
ℹ️ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

8fdd883 - [pfe-avatar] begin removing extraneous avatar tools

  • ❌ subject may not be empty
  • ❌ type may not be empty

@Nouveau Nouveau linked an issue Oct 20, 2022 that may be closed by this pull request
[1:1] pfe-avatar #2048
Closed
@github-actions github-actions bot added the AT passed Automated testing has passed label Oct 20, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022 •
edited
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 63f984a
😎 Deploy Preview https://deploy-preview-2188--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@bennypowers bennypowers changed the title [Draft] feat(avatar): PF1:1 feat(avatar): PF1:1 Oct 21, 2022
@github-actions github-actions bot added the doc label Nov 14, 2022
@Nouveau Nouveau force-pushed the feat/pfe-avatar-1-1 branch from 7ce832e to 94539e6 Compare November 28, 2022 07:33
@Nouveau Nouveau marked this pull request as ready for review December 1, 2022 15:24
bennypowers
bennypowers requested changes Dec 1, 2022
View reviewed changes
Copy link
Member

@bennypowers bennypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good Em

A few changes then we'll be ready to merge

@bennypowers bennypowers enabled auto-merge (squash) December 8, 2022 09:41
@bennypowers bennypowers disabled auto-merge December 8, 2022 09:42
@bennypowers bennypowers merged commit 21f7fa8 into main Dec 8, 2022
@bennypowers bennypowers deleted the feat/pfe-avatar-1-1 branch December 8, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers approved these changes

Assignees

@Nouveau Nouveau

Labels

1:1 Aligning components with PatternFly v4 AT passed Automated testing has passed demo Updating demo pages docs Documentation updates functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass tests Related to testing work in progress POC / Not ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[1:1] pfe-avatar

3 participants

@Nouveau @bennypowers