Sync with upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed By: frantic Differential Revision: D3428952 fbshipit-source-id: 61e5195399746d6511719971121c7c63f87ef4f4
Reviewed By: bestander Differential Revision: D3508704 fbshipit-source-id: 82c38819a83a50e0d5ba25480b5b4b7290c92e13
Summary: **Motivation** The prop validation was run on every render, even in prod which seems odd to me. This adds a dev check to make sure prod build skips the validation. **Test plan (required)** There are no changes to the ui. Closes #8499 Differential Revision: D3508805 Pulled By: javache fbshipit-source-id: 68c6a1224e33997f9df93481426daff790ef5bcd
Summary: Found a couple of places where we were copy-pasting the logic `ResourceDrawableIdHelper` had. This class was only available on the image module and it had package visibility. I moved it to its own module so that we can easily use it from others. This diff is pretty simillar to 54ed446 but it fixes a bug due to which we had to revert it. Reviewed By: andreicoman11 Differential Revision: D3499062 fbshipit-source-id: f912f57e5ac21a9f30fe42067c784f49fa46ed48
Summary: Currently, DevTools only work under ios (although this is undocumented!), because the JavaScriptEngine initialization process skips setupDevTools() on android. DevTools work fine with Android, as tested on 0.26, 0.27, and 0.28 using Nuclide's inspector. For reference, the relevant issue on react-devtools. Closes #8095 Reviewed By: bestander Differential Revision: D3492788 Pulled By: andreicoman11 fbshipit-source-id: 1eda9196d7125da19a8d7baaab22b61b744ca629
Summary: This allows the `NavigationCard` style to be extended, the default `backgroundColor` style of the `NavigationCard` is not applicable to all apps. Fixes issue #8116. PR #8115 was already made for this but didn't pass CI checks. **Test plan** When rendering a NavigationCardStack, add ``` const { CardStack } = NavigationExperimental; ... <CardStack cardStyle={{ backgroundColor: 'purple' }} /> ``` to see that the `NavigationCard` background has changed to purple. Closes #8471 Differential Revision: D3508849 Pulled By: javache fbshipit-source-id: 65703cccf3d01def9f2060256f0ff564bbdc47d3
Reviewed By: michalgr Differential Revision: D3497518 fbshipit-source-id: 615679fdfa22f9a03535248ebaa80ff9aa2e9e71
Summary: There's a typo, CGMakeRect is really CGRectMake https://developer.apple.com/reference/coregraphics/1455245-cgrectmake Closes #8524 Differential Revision: D3508996 Pulled By: bestander fbshipit-source-id: 67270ba52b97bbf4e2a5afd97cfb04647e5aad62
Reviewed By: bestander Differential Revision: D3509026 fbshipit-source-id: d7db3de13ecc92f6ddfdcec3029c78915e1e66c0
Summary: Move ImageSource out of ReactImageView so it can be used by other views dealing with images. Make ResourceDrawableIdHelper static in the process. Reviewed By: dmmiller Differential Revision: D3505103 fbshipit-source-id: 776a5b22a6934eeaa370826cb71c00cd937d3187
Reviewed By: andreicoman11 Differential Revision: D3505224 fbshipit-source-id: e731325af7fd0c1cbd600695607302c968e0f36e
Reviewed By: andreicoman11 Differential Revision: D3509011 fbshipit-source-id: 96fe96f28da24efb00b98589cea28e6c9cfc7180
Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: (You can skip this if you're fixing a typo or adding an app to the Showcase.) Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/mas Closes #7535 Differential Revision: D3509757 fbshipit-source-id: 70ff6c9c137c766ccb1173921f08571f48cb4f0b
Summary: This should have literally no changes from the RC that affect RN -- just a version bump. Reviewed By: vjeux Differential Revision: D3511116 fbshipit-source-id: 5bb3a330c0d2e78a2f3dfbb0e948c99607d2e66e
Reviewed By: astreet Differential Revision: D3507482 fbshipit-source-id: b62f3bf0fe1dd4f49594e441f4e00b9e20ec972b
Summary: The keys were in random order which made this warning less useful when there are many keys. Reviewed By: spicyj Differential Revision: D3504322 fbshipit-source-id: c184aa447c985a0149cbfa8c90c6daf9632b6226
Differential Revision: D3510867 fbshipit-source-id: b4f3300ef003c57aa7d4f3513bca537c464f7647
Differential Revision: D3510867 fbshipit-source-id: 365eb22e143f1c0eec6e4b8810c93dbb0e9fbbfa
Summary: This should revert back to using old bridge by default until we fix gradle script to build new bridge for OSS correctly Closes #8539 Differential Revision: D3514263 Pulled By: bestander fbshipit-source-id: db9e0232b9bde27206814212dedc487c366e3511
Summary: Add `phone-pad` as one of cross-platform values to `keyboardType`. Closes #8555 Differential Revision: D3515002 Pulled By: JoelMarcey fbshipit-source-id: 4f30dd72e8e30905a8a5fb90d3f361fb58eb825e
Reviewed By: michalgr Differential Revision: D3514778 fbshipit-source-id: 29dc12ad0a701fd08262be3aa81ae990d4fc63a9
Reviewed By: javache Differential Revision: D3514703 fbshipit-source-id: 8195778b23868eae36a55edc2d5d4f148b36a12e
Summary: We did a survey prior to the doc lockdown to get an idea of what we should focus on. Now we have a yes/no style survey to ensure that we met the user needs when it came to our start of improving the docs. This diff adds the survey link to the bottom of each page. And we will cherry-pick it into 0.29 as well, which will be the first official release with the new doc content > **NOTE**: The content via the links in this survey will not be valid until 0.29 is actually released. So I have not enabled the questions for the survey until then. **Test Plan:** http://localhost:8079/react-native/docs/getting-started.html <img width="753" alt="screenshot 2016-07-01 17 35 17" src="https://cloud.githubusercontent.com/assets/3757713/16535354/987dd3a8-3fb4-11e6-81b7-1a1fcffd3bb2.png"> Closes #8530 Differential Revision: D3515242 Pulled By: JoelMarcey fbshipit-source-id: c2d241d472853dfb3f9e7d3ae9560b318aacb866
Summary: --tags pushes all tags, which is rarely what we want. --follow-tags pushes only the tags in the commits that are being pushed. Closes #8531 Differential Revision: D3515530 fbshipit-source-id: c951ee1c6170286c5fee0191cc375657a299e34a
Reviewed By: kentaromiura Differential Revision: D3516030 fbshipit-source-id: 739003d8c1984207312b650e424397a419c5eb6a
Reviewed By: javache Differential Revision: D3516105 fbshipit-source-id: ea92714378f3d2be189b59b1b76d3e689aeac4c7
Summary: These are helpful for development and shouldn't affect anything when DEBUG=false Reviewed By: lexs Differential Revision: D3515015 fbshipit-source-id: 0bd5ff833f90fea8e70b3103eb1f9bc803bef27c
Summary: Right now systrace generates an html file that is using the Object.observe function which is now deprecated in most up to date browsers. Since we don't want to depend on the systrace being up to date, we should advise opening the trace through the Tracing tool, since that is the only way to get it working until systrace removes its dependency on Object.observe. Closes #7880 Differential Revision: D3516305 Pulled By: astreet fbshipit-source-id: ab9ae46ba74b7a34b6cfb8c37ca1ec2e6b41e353
Summary:
Idle WebSocket connections get reset after a few minutes of inactivity. To prevent this, most WebSocket implementations offer sending special ping messages. This PR adds a method `sendPing()` to WebSocket. Ping payloads are not supported.
Manual testing can be done by adding `connection.on('ping', _ => console.log('Received ping'));` to a ws connection or using a packet sniffer while sending pings.
Closes #8505
Differential Revision: D3516260
Pulled By: dmmiller
fbshipit-source-id: cfebf5899188ae53254d5be6b666a9075e0eed89
Reviewed By: majak Differential Revision: D3175793 fbshipit-source-id: e1e66e3dcde8b1fb35973340e12d947a0e955775
Reviewed By: majak Differential Revision: D3423580 fbshipit-source-id: c063c9c5d8961d5c9cb14c32d70767c67d78430a
Reviewed By: majak Differential Revision: D3424412 fbshipit-source-id: 933925b97cb2bdfabd84c3533fefb01efb41d030
Reviewed By: bhosmer Differential Revision: D3563060 fbshipit-source-id: b6fe913b312c45234d1685524efebd7249d20741
Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: > **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.** (You can skip this if you're fixing a typo or adding an app to the Showcase.) Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/face Closes #8869 Differential Revision: D3580218 Pulled By: JoelMarcey fbshipit-source-id: 9f71825ed0a63739497ec7fa77081df0a72b6747
Summary: s/_renderSeperator/_renderSeparator/ Closes #8816 Differential Revision: D3580181 Pulled By: javache fbshipit-source-id: e9cf35d50512b490efafa880f8d99ca13aa4df15
Reviewed By: javache Differential Revision: D3517605 fbshipit-source-id: a2efba80bbe1f6c74bf4e01f7807389962cb2463
Reviewed By: javache Differential Revision: D3579609 fbshipit-source-id: c108bbe135a0a9a98045ebc8068a103c892a1d0f
Reviewed By: dmmiller Differential Revision: D3553287 fbshipit-source-id: ea33bb7d929cbc0229bfe8537c3a4fc58fe9691e
Reviewed By: AaaChiuuu Differential Revision: D3558831 fbshipit-source-id: b3909de774922fae903f3e8718fbfcd9b1ece2f8
… a stylesheet
Summary:
I thought it would be useful to help clear out references to no longer used styles and also catch typos on style names to have flow error when we try to access a style that isn't defined.
Example:
```javascript
export default class AuthenticationScreen extends React.Component {
render() {
// This throws an error because `continer` is misspelled
return (
<View style={styles.continer} />
)
}
}
const styles = StyleSheet.create({
container: {
flex: 1,
},
}
```
```javascript
export default class AuthenticationScreen extends React.Component {
render() {
// This throws an error because no fancyContainer style is defined
return (
<View style={[styles.container, styles.fancyContainer]} />
)
}
}
const styles = StyleSheet.create({
container: {
flex: 1,
},
}
```
All credit goes to jeffmo in this tweet: https://twitter.com/lbljeffmo/status/755179096271888385
Also included in the PR is some cleanup on styles that
Closes #8876
Differential Revision: D3584983
Pulled By: yungsters
fbshipit-source-id: 0ee0e12ff3d976c137d932688e323c26690e0a52
Summary: UIExplorerApp.ios.js is moved into js directory. Closes #8884 Differential Revision: D3586032 Pulled By: nathanajah fbshipit-source-id: 93793681e33a0922e3d8503da3f1c0d01fd4fa93
Summary: **Motivation** : Debugging RN with Stetho is very helpful but not very well documented. **Result Screenshot**  Closes #8883 Differential Revision: D3586063 fbshipit-source-id: e55ebee0d1e1eedb109bec307c313942bc70b646
Reviewed By: javache Differential Revision: D3569816 fbshipit-source-id: ab03f3f3ad10b3921d428628c87e4091c07ceafe
Summary: Addresses this comment: #2296 (comment) This pull request adds the `center` value to `ImageResizeMode`. When set, it will center the image within its frame. If the image is larger than its frame, the image is downscaled while maintaining its aspect ratio. That is how the Android implementation works, too. Sorry, don't have time to write tests. 😢 Any reviewers should make sure `RCTTargetRect` returns the correct value when: - the image is smaller than its frame (ie: no downscaling needed) - the image is larger than its frame (should be downscaled to avoid clipping) Closes #8792 Differential Revision: D3586134 Pulled By: javache fbshipit-source-id: 78fb8e5928284003437dac2c9ad264fa584f73ec
Summary: Installing react-native gives a warning because of outdated version of yeoman-generator. The warning is ```npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue```. This MR will update the yeoman-generator version to 0.21.0 to resolve this warning. Closes #8859 Reviewed By: matryoshcow Differential Revision: D3580087 Pulled By: bestander fbshipit-source-id: 4daddd804679ab8e95e59cf0d0005f87d2f48e1c
Summary: Closes #8886 Differential Revision: D3586269 fbshipit-source-id: d6dc0a3618f3c1c4516ce428dd525b3f8aa09d3c
Summary: The `setupDevtools` for Android looks coming on [v0.30](22fbb6d), currently we need to run `adb reverse tcp:8097 tcp:8097`, I think get host IP (`10.0.2.2`, Genymotion: `10.0.3.2`) for Android will be better. (it can be found in `AndroidConstants` native module) Closes #8811 Differential Revision: D3586177 Pulled By: javache fbshipit-source-id: 3bfe04391b0fea608e4d3deab03dd376fab8727c
Summary: Add some additional perf markers, and remove the usage of RCTProfileBlock as it completely breaks debugging / stepping in those blocks. Reviewed By: majak Differential Revision: D3579900 fbshipit-source-id: 8846dfc39b2448daa3669d5e1e8efb9096f183c5
Summary: Just a small update to fix the error message in `Alert.js`. In my app, I'm using https://github.com/zo0r/react-native-push-notification to show local notifications. When the notification is tapped, I'm trying to show an alert with the notification text, but this results in an error (which is not the problem I'm addressing here). Unfortunately the wrong parameter was passed to the `console.warn`, so you couldn't see what the error message was. Before: <img width="416" alt="bildschirmfoto 2016-07-18 um 10 50 35" src="https://cloud.githubusercontent.com/assets/666322/16910168/7b45c7ac-4cd7-11e6-8d3e-3861d2fc648c.png"> <img width="416" alt="bildschirmfoto 2016-07-18 um 10 50 43" src="https://cloud.githubusercontent.com/assets/666322/16910173/854fc0ea-4cd7-11e6-956f-93ee68a09bd6.png"> After fix: <img width="416" alt="bildschirmfoto 2016-07-18 um 10 50 35" src="https://cloud.githubusercontent.com/assets/666322/16910168/7b45c7ac-4cd7-11e6-8d3e-3861d2fc648c.png"> <img width="416" alt="bildschirmfoto 2016 Closes #8861 Differential Revision: D3586453 fbshipit-source-id: bf81e42bd4450ef15a301e7367e94355379c442e
Summary: Change modal.js to support RTL Reviewed By: javache Differential Revision: D3580776 fbshipit-source-id: e9ef3f340f52e38fd905dce6d14a74d3bd7b7982
Reviewed By: emilsjolander Differential Revision: D3588423 fbshipit-source-id: ad2486b3da5fe7972e4ea9409a729d2ba2483782
Summary: fillCSSNode was only ever used in RCTShadowView to set the child count which is already performed in insert/remove subview calls and in RCTShadowText is was used to set the measure function which can be done in the initializer instead. Reviewed By: majak, javache Differential Revision: D3586418 fbshipit-source-id: de2155daf0f1702c8977bf23183a3b6a650d016b
Summary: RCTShadowText currently overrides a couple methods from RCTShadowView to reset the count of the cssNode children to 0. This diff instead moves that logic into RCTShadowView behind a configurable flag making it easier to reason about. Reviewed By: javache Differential Revision: D3586434 fbshipit-source-id: 4389a8119dc49e3fc4357174c87c0c69287ae385
…pport Summary: This PR was split from commits originally in #8619. /cc dmmiller These refactorings to the HierarchyOptimizer are in preparation for implementing support for inline views in #8619. **Refactoring 1: Collapse add*LayoutOnlyNodeToLayoutOnlyNode** addLayoutOnlyNodeToLayoutOnlyNode and addNonLayoutOnlyNodeToLayoutOnlyNode had nearly identical implementations. They both walk thru the ancestors looking for a nonlayout-only node and adjusting the passed in index at each step. This introduces a new function, walkUpUntilNonLayoutOnly, which takes care of that responsibility. This simplifies addNodeToNode because it can now consider the type of the parent and the type of the child independently. **Refactoring 2: Extract addGrandchildren** Pull out addLayoutOnlyNode's logic into a helper called addGrandchildren. We will need to call this method in another place later. **Test plan (required)** This change was tested with UIExplorer and a small test app and it's being used in my team's app. Closes #8908 Differential Revision: D3592783 Pulled By: dmmiller fbshipit-source-id: a513e8d381e71112ce6348bbee7d4a7c62c33619
Reviewed By: lexs Differential Revision: D3347854 fbshipit-source-id: 95b81152d1b0d5fe41e01991c44f5d1110be7ddb
Summary: Makes sure request for geolocation use in the webview is handled. This solves issue #7609 Currently use of geolocation in webview fails silently, as the permission request is never received by the native app. **Test plan (required)** 1. Create new project with webview 2. Add javascript for geolocation: ```javascript navigator.geolocation.getCurrentPosition(function (position) { console.log('success', position) }, function (error) { console.log('could not determine position', error) }) ``` 3. Run code and assert geolocation permission is requested, resulting in success (or error) callback being called Closes #8305 Differential Revision: D3592887 fbshipit-source-id: 84fe2383fba8873431c5e89d154c0a4fd58ffb70
SergeyKorochansky
pushed a commit
that referenced
this pull request
Jul 20, 2016
Reviewed By: avaly Differential Revision: D3366104 fbshipit-source-id: 1c77b29e28726a6a105317d9f6944bbf78b707d7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.