[TextInput] Add __DEV__ around textInput prop check #8499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the input component is validating props in production on each render which didn't seem very efficient. This ensures it's only run in development.
dozoisch
changed the title
|
By analyzing the blame information on this pull request, we identified @JoelMarcey and @Bhullnatik to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
dozoisch
changed the title
Member
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Contributor
|
Can you change this from an error to a warning? Really don't want different failure modes between dev and prod. |
Contributor
Author
|
@ide if there's a consensus, I don't mind making another PR! |
Member
|
@ide this seems similar to how we do other propType validation, so I think it's fine. https://github.com/facebook/react/blob/master/src/isomorphic/classic/types/ReactPropTypes.js#L149 |
Contributor
|
@javache React creates Errors in order to capture the stack trace but it doesn't throw them. It prints a warning during propType validation: https://github.com/facebook/react/blob/95ac239cf3c527b70daeb433b7aeeaf9e41be9e5/src/isomorphic/classic/types/checkReactTypeSpec.js#L84 |
Contributor
Author
|
@ide so should we change it so that it only prints it instead of throwing? |
Contributor
|
Yea I think we want to follow what React does with |
dozoisch
added a commit
to dozoisch/react-native
that referenced
this pull request
Jul 8, 2016
- the goal is to have the same failure mode in prod and dev. See conv in facebook#8499
Contributor
Author
|
@ide dozoisch@534d6ce would that be ok with you? If yes, I'll create a pr. Sorry for not responding, never saw your response 3 days ago! |
dozoisch
added a commit
to dozoisch/react-native
that referenced
this pull request
Jul 13, 2016
- the goal is to have the same failure mode in prod and dev. See conv in facebook#8499
ghost
pushed a commit
that referenced
this pull request
Jul 13, 2016
Summary: Follow up of #8499! Open to discussion Motivation: See #8499 (comment) Goal is to have the same failure mode in dev and prod. /cc ide Closes #8757 Differential Revision: D3558991 fbshipit-source-id: c7d133f958e67ab23da486b1ffcb8f9963509b79
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: **Motivation** The prop validation was run on every render, even in prod which seems odd to me. This adds a dev check to make sure prod build skips the validation. **Test plan (required)** There are no changes to the ui. Closes facebook#8499 Differential Revision: D3508805 Pulled By: javache fbshipit-source-id: 68c6a1224e33997f9df93481426daff790ef5bcd
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Follow up of facebook#8499! Open to discussion Motivation: See facebook#8499 (comment) Goal is to have the same failure mode in dev and prod. /cc ide Closes facebook#8757 Differential Revision: D3558991 fbshipit-source-id: c7d133f958e67ab23da486b1ffcb8f9963509b79
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: **Motivation** The prop validation was run on every render, even in prod which seems odd to me. This adds a dev check to make sure prod build skips the validation. **Test plan (required)** There are no changes to the ui. Closes facebook#8499 Differential Revision: D3508805 Pulled By: javache fbshipit-source-id: 68c6a1224e33997f9df93481426daff790ef5bcd
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Follow up of facebook#8499! Open to discussion Motivation: See facebook#8499 (comment) Goal is to have the same failure mode in dev and prod. /cc ide Closes facebook#8757 Differential Revision: D3558991 fbshipit-source-id: c7d133f958e67ab23da486b1ffcb8f9963509b79
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: **Motivation** The prop validation was run on every render, even in prod which seems odd to me. This adds a dev check to make sure prod build skips the validation. **Test plan (required)** There are no changes to the ui. Closes facebook/react-native#8499 Differential Revision: D3508805 Pulled By: javache fbshipit-source-id: 68c6a1224e33997f9df93481426daff790ef5bcd
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: Follow up of facebook/react-native#8499! Open to discussion Motivation: See facebook/react-native#8499 (comment) Goal is to have the same failure mode in dev and prod. /cc ide Closes facebook/react-native#8757 Differential Revision: D3558991 fbshipit-source-id: c7d133f958e67ab23da486b1ffcb8f9963509b79
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The prop validation was run on every render, even in prod which seems odd to me. This adds a dev check to make sure prod build skips the validation.
Test plan (required)
There are no changes to the ui.