Change TextInput prop check to print instead of throw #8757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @JoelMarcey and @Bhullnatik to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| for (var propKey in onlyMultiline) { | ||
| if (props[propKey]) { | ||
| throw new Error( | ||
| console.error(new Error( |
Contributor
There was a problem hiding this comment.
Use the same warning method that React uses:
warning(false, '%s', error.stack);
Contributor
|
Thanks for following up! |
- the goal is to have the same failure mode in prod and dev. See conv in facebook#8499
dozoisch
force-pushed
the
textinput_followup
branch
from
534d6ce to
11f0412
Compare
Contributor
Author
|
@ide Ok, I've updated it! |
Contributor
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: Follow up of facebook#8499! Open to discussion Motivation: See facebook#8499 (comment) Goal is to have the same failure mode in dev and prod. /cc ide Closes facebook#8757 Differential Revision: D3558991 fbshipit-source-id: c7d133f958e67ab23da486b1ffcb8f9963509b79
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: Follow up of facebook#8499! Open to discussion Motivation: See facebook#8499 (comment) Goal is to have the same failure mode in dev and prod. /cc ide Closes facebook#8757 Differential Revision: D3558991 fbshipit-source-id: c7d133f958e67ab23da486b1ffcb8f9963509b79
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: Follow up of facebook/react-native#8499! Open to discussion Motivation: See facebook/react-native#8499 (comment) Goal is to have the same failure mode in dev and prod. /cc ide Closes facebook/react-native#8757 Differential Revision: D3558991 fbshipit-source-id: c7d133f958e67ab23da486b1ffcb8f9963509b79
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #8499! Open to discussion
Motivation:
See #8499 (comment)
Goal is to have the same failure mode in dev and prod.
/cc @ide