Get server host in setupDevtools for Android #8811
Closed
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @yungsters and @sebmarkbage to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
ghost
added
the
CLA Signed
ghost
added
the
CLA Signed
Member
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
fadils
pushed a commit
to fadils/react-native
that referenced
this pull request
Jul 21, 2016
Summary: The `setupDevtools` for Android looks coming on [v0.30](facebook@22fbb6d), currently we need to run `adb reverse tcp:8097 tcp:8097`, I think get host IP (`10.0.2.2`, Genymotion: `10.0.3.2`) for Android will be better. (it can be found in `AndroidConstants` native module) Closes facebook#8811 Differential Revision: D3586177 Pulled By: javache fbshipit-source-id: 3bfe04391b0fea608e4d3deab03dd376fab8727c
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: The `setupDevtools` for Android looks coming on [v0.30](facebook@22fbb6d), currently we need to run `adb reverse tcp:8097 tcp:8097`, I think get host IP (`10.0.2.2`, Genymotion: `10.0.3.2`) for Android will be better. (it can be found in `AndroidConstants` native module) Closes facebook#8811 Differential Revision: D3586177 Pulled By: javache fbshipit-source-id: 3bfe04391b0fea608e4d3deab03dd376fab8727c
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: The `setupDevtools` for Android looks coming on [v0.30](facebook@22fbb6d), currently we need to run `adb reverse tcp:8097 tcp:8097`, I think get host IP (`10.0.2.2`, Genymotion: `10.0.3.2`) for Android will be better. (it can be found in `AndroidConstants` native module) Closes facebook#8811 Differential Revision: D3586177 Pulled By: javache fbshipit-source-id: 3bfe04391b0fea608e4d3deab03dd376fab8727c
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: The `setupDevtools` for Android looks coming on [v0.30](facebook/react-native@22fbb6d), currently we need to run `adb reverse tcp:8097 tcp:8097`, I think get host IP (`10.0.2.2`, Genymotion: `10.0.3.2`) for Android will be better. (it can be found in `AndroidConstants` native module) Closes facebook/react-native#8811 Differential Revision: D3586177 Pulled By: javache fbshipit-source-id: 3bfe04391b0fea608e4d3deab03dd376fab8727c
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setupDevtoolsfor Android looks coming on v0.30, currently we need to runadb reverse tcp:8097 tcp:8097, I think get host IP (10.0.2.2, Genymotion:10.0.3.2) for Android will be better. (it can be found inAndroidConstantsnative module)