FIX CGMakeRect is really CGRectMake #8524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @bestander and @sebmarkbage to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
CLA Signed
Contributor
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: There's a typo, CGMakeRect is really CGRectMake https://developer.apple.com/reference/coregraphics/1455245-cgrectmake Closes facebook#8524 Differential Revision: D3508996 Pulled By: bestander fbshipit-source-id: 67270ba52b97bbf4e2a5afd97cfb04647e5aad62
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: There's a typo, CGMakeRect is really CGRectMake https://developer.apple.com/reference/coregraphics/1455245-cgrectmake Closes facebook#8524 Differential Revision: D3508996 Pulled By: bestander fbshipit-source-id: 67270ba52b97bbf4e2a5afd97cfb04647e5aad62
react-one
pushed a commit
to react-one/react-native
that referenced
this pull request
Sep 24, 2021
Allows you to subscribe to gesture navigation events, we have a custom keyboard that we want to hide and show when gesture is being used to navigate (same as native keyboard)
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: There's a typo, CGMakeRect is really CGRectMake https://developer.apple.com/reference/coregraphics/1455245-cgrectmake Closes facebook/react-native#8524 Differential Revision: D3508996 Pulled By: bestander fbshipit-source-id: 67270ba52b97bbf4e2a5afd97cfb04647e5aad62
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a typo, CGMakeRect is really CGRectMake
https://developer.apple.com/reference/coregraphics/1455245-cgrectmake