Remove CUIICatalog invalid asset name supplied error #7535

mmckinley8 · 2016-05-12T16:07:26Z

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

(You can skip this if you're fixing a typo or adding an app to the Showcase.)

Explain the motivation for making this change. What existing problem does the pull request solve?

Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Make sure tests pass on both Travis and Circle CI.

Code formatting

Look around. Match the style of the rest of the codebase. See also the simple style guide.

For more info, see the "Pull Requests" section of our "Contributing" guidelines.

TabBarIOS icons were showing up as invalid strings, causing crashes on some devices.

Test plan

Set a symbolic breakpoint in xcode -
Sybmol: [UIImage imageNamed:]
Condition: $arg3 == nil

If the app crashes with this breakpoint added, this PR will resolve it. You will no longer see:
CUIICatalog invalid asset name supplied (null)

ghost · 2016-05-12T16:08:23Z

By analyzing the blame information on this pull request, we identified @nicklockwood and @ryangomba to be potential reviewers.

ghost · 2016-05-12T16:08:24Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

ghost · 2016-05-12T18:46:40Z

@mmckinley8 updated the pull request.

ghost · 2016-05-12T18:46:41Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

ide · 2016-05-12T19:02:09Z

Add an explicit nil check to fix the root cause instead of patching the symptom.

nicklockwood · 2016-05-12T22:09:59Z

React/Base/RCTConvert.m

  if ([scheme isEqualToString:@"file"]) {
    NSString *assetName = RCTBundlePathForURL(URL);
-    image = [UIImage imageNamed:assetName];
+    image = [UIImage imageNamed:[NSString stringWithFormat:@"%@", assetName]];


I agree with @ide. I suggest changing this to:

image = assetName ? [UIImage imageNamed:assetName] : nil;

Totally agree, thanks @ide and @nicklockwood ...what needs to be changed in order to pass the Travis CI?

…ct-native into CUICatalog-error-solution

ghost · 2016-05-13T15:26:20Z

@mmckinley8 updated the pull request.

facebook-github-bot · 2016-05-16T17:20:15Z

@mmckinley8 updated the pull request.

ghost · 2016-05-17T15:13:35Z

@mmckinley8 updated the pull request.

ghost · 2016-05-19T16:29:17Z

@mmckinley8 updated the pull request.

ghost · 2016-05-31T17:41:24Z

@mmckinley8 updated the pull request.

ghost · 2016-07-01T17:00:44Z

It's been a while since the last commit was reviewed and the labels show this pull request needs review. Based on the blame information for the files in this pull request we identified @nicklockwood as a potential reviewer. Could you take a look please or cc someone with more context?

ide · 2016-07-01T17:27:30Z

@facebook-github-bot shipit

facebook-github-bot · 2016-07-01T17:27:57Z

Thanks for importing. If you are an FB employee go to Phabricator to review.

Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: (You can skip this if you're fixing a typo or adding an app to the Showcase.) Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/mas Closes facebook#7535 Differential Revision: D3509757 fbshipit-source-id: 70ff6c9c137c766ccb1173921f08571f48cb4f0b

atkit · 2018-01-30T15:09:58Z

Also happens in RCTImageFromLocalAssetURL, might be regression

Summary: Thanks for submitting a pull request! Please provide enough information so that others can review your pull request: (You can skip this if you're fixing a typo or adding an app to the Showcase.) Explain the **motivation** for making this change. What existing problem does the pull request solve? Prefer **small pull requests**. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. **Test plan (required)** Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI. Make sure tests pass on both Travis and Circle CI. **Code formatting** Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide). For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/mas Closes facebook/react-native#7535 Differential Revision: D3509757 fbshipit-source-id: 70ff6c9c137c766ccb1173921f08571f48cb4f0b

Remove CUIICatalog invalid asset name supplied error

9ef596e

ghost added the GH Review: review-needed label May 12, 2016

Merge branch 'master' into CUICatalog-error-solution

781457e

ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 12, 2016

nicklockwood reviewed May 12, 2016
View reviewed changes

mmckinley8 added 3 commits May 13, 2016 10:24

add explicit nil check

1c4ea99

Merge branch 'CUICatalog-error-solution' of github.com:mmckinley8/rea…

4992c5d

…ct-native into CUICatalog-error-solution

Merge branch 'master' into CUICatalog-error-solution

ce35866

mmckinley8 closed this May 16, 2016

mmckinley8 reopened this May 16, 2016

Merge branch 'master' into CUICatalog-error-solution

1afde2a

Merge branch 'master' into CUICatalog-error-solution

2e45cea

mmckinley8 closed this May 17, 2016

mmckinley8 reopened this May 17, 2016

Merge branch 'master' into CUICatalog-error-solution

0f315d3

Merge branch 'master' into CUICatalog-error-solution

5b3ea8d

ghost added GH Review: accepted and removed GH Review: review-needed labels Jul 1, 2016

ghost added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jul 1, 2016

ghost closed this in 6424c8b Jul 1, 2016

This pull request was closed.

Remove CUIICatalog invalid asset name supplied error #7535

Remove CUIICatalog invalid asset name supplied error #7535

Uh oh!

Conversation

mmckinley8 commented May 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented May 12, 2016

Uh oh!

ghost commented May 12, 2016

Uh oh!

ghost commented May 12, 2016

Uh oh!

ghost commented May 12, 2016

Uh oh!

ide commented May 12, 2016

Uh oh!

nicklockwood May 12, 2016

Choose a reason for hiding this comment

Uh oh!

mmckinley8 May 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost commented May 13, 2016

Uh oh!

facebook-github-bot commented May 16, 2016

Uh oh!

ghost commented May 17, 2016

Uh oh!

ghost commented May 19, 2016

Uh oh!

ghost commented May 31, 2016

Uh oh!

ghost commented Jul 1, 2016

Uh oh!

ide commented Jul 1, 2016

Uh oh!

facebook-github-bot commented Jul 1, 2016

Uh oh!

atkit commented Jan 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mmckinley8 commented May 12, 2016 •

edited

Loading

mmckinley8 May 13, 2016 •

edited

Loading

atkit commented Jan 30, 2018 •

edited

Loading