Skip to content

Fix minor typo in ListViewExample.js #8816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eronisko wants to merge 1 commit into from
Closed

Fix minor typo in ListViewExample.js #8816

eronisko wants to merge 1 commit into from

Conversation

@eronisko
Copy link
Contributor

@eronisko eronisko commented Jul 15, 2016

s/_renderSeperator/_renderSeparator/

@eronisko
Fix minor typo in ListViewExample.js
376db08 
s/_renderSeperator/_renderSeparator/
@ghost
Copy link

ghost commented Jul 15, 2016

By analyzing the blame information on this pull request, we identified @geirman and @javache to be potential reviewers.

@ghost
Copy link

ghost commented Jul 15, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@javache
Copy link
Member

javache commented Jul 15, 2016

@facebook-github-bot shipit

@ghost
Copy link

ghost commented Jul 15, 2016

I cannot do that @javache, because @eronisko does not have an active CLA on file.

@ghost ghost added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 15, 2016
@ghost
Copy link

ghost commented Jul 15, 2016

Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this.

@ghost ghost added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Jul 15, 2016
@geirman
Copy link
Contributor

geirman commented Jul 16, 2016

Ah, good catch. Guess I don't spell so good ;)

@eronisko make sure you sign the CLA so we can ship this

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2016
@eronisko
Copy link
Contributor Author

eronisko commented Jul 17, 2016

CLA signed.

@ghost
Copy link

ghost commented Jul 17, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@javache
Copy link
Member

javache commented Jul 18, 2016

@facebook-github-bot shipit

@ghost
Copy link

ghost commented Jul 18, 2016

I cannot do that @javache, because @eronisko does not have an active CLA on file.

@ghost ghost added Import Started This pull request has been imported. This does not imply the PR has been approved. CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Jul 18, 2016
@ghost
Copy link

ghost commented Jul 18, 2016

Something went wrong when importing this pull request. Please cc someone from the team at fb to help with importing this.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2016
@javache
Copy link
Member

javache commented Jul 18, 2016

@facebook-github-bot shipit

@ghost ghost added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jul 18, 2016
@ghost
Copy link

ghost commented Jul 18, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review internal test results.

@ghost ghost added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2016
@ghost ghost closed this in 8333613 Jul 18, 2016
fadils pushed a commit to fadils/react-native that referenced this pull request Jul 21, 2016
@eronisko @fadils
Fix minor typo in ListViewExample.js
cbcf164 
Summary:
s/_renderSeperator/_renderSeparator/
Closes facebook#8816

Differential Revision: D3580181

Pulled By: javache

fbshipit-source-id: e9cf35d50512b490efafa880f8d99ca13aa4df15
rozele pushed a commit to microsoft/react-native-windows that referenced this pull request Jul 26, 2016
@eronisko
Fix minor typo in ListViewExample.js
7211aa1 
Summary:
s/_renderSeperator/_renderSeparator/
Closes facebook/react-native#8816

Differential Revision: D3580181

Pulled By: javache

fbshipit-source-id: e9cf35d50512b490efafa880f8d99ca13aa4df15
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
@eronisko @bubblesunyum
Fix minor typo in ListViewExample.js
eba3934 
Summary:
s/_renderSeperator/_renderSeparator/
Closes facebook#8816

Differential Revision: D3580181

Pulled By: javache

fbshipit-source-id: e9cf35d50512b490efafa880f8d99ca13aa4df15
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
@eronisko
Fix minor typo in ListViewExample.js
216dc5d 
Summary:
s/_renderSeperator/_renderSeparator/
Closes facebook#8816

Differential Revision: D3580181

Pulled By: javache

fbshipit-source-id: e9cf35d50512b490efafa880f8d99ca13aa4df15
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
@eronisko @seraj-ahmad
Fix minor typo in ListViewExample.js
e3b30a5 
Summary:
s/_renderSeperator/_renderSeparator/
Closes facebook/react-native#8816

Differential Revision: D3580181

Pulled By: javache

fbshipit-source-id: e9cf35d50512b490efafa880f8d99ca13aa4df15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eronisko @javache @geirman @ide @facebook-github-bot