Update Android Performance for opening trace.html #7880
Conversation
|
By analyzing the blame information on this pull request, we identified @astreet and @bestander to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
@xvalentino updated the pull request. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
CLA Signed
|
Thanks! If Object.observe isn't available, doesn't it crash the tab instead of bring blank? It might be worthwhile to show a screenshot of what it looks like when they need to manually load... |
|
@astreet In my experience, the page is blank (at least in Chrome) and if you open the console you get something along the lines of "Object.observe is not a function". I think images would definitely help though. |
@xvalentino Could you add a screenshot please? |
|
ReactNative 0.26 |
|
I'll confirm @hufeng this is the latest view when this happens. This is what I got in 0.24
Then I'll update the PR. Thanks all! |
|
React-Native 0.27 only shows a blank page. Looks like the page varies from React-Native versions. All consistently show |
|
Viewing the markdown on my repo doesn't display any of the images, should work but let's make sure I'm actually showing the image. |
|
@xvalentino You can run the website locally using |
Since Object.observe was depreacted, there may be more you must do to view the trace in newer browsers
|
Thank you @mkonicek Should be all set. |
|
@facebook-github-bot shipit Thanks! |
|
@astreet sorry it looks like there was some kind of failing test before, merge please! Thank you! |
|
I still get the following error. |
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Summary: Right now systrace generates an html file that is using the Object.observe function which is now deprecated in most up to date browsers. Since we don't want to depend on the systrace being up to date, we should advise opening the trace through the Tracing tool, since that is the only way to get it working until systrace removes its dependency on Object.observe. Closes facebook#7880 Differential Revision: D3516305 Pulled By: astreet fbshipit-source-id: ab9ae46ba74b7a34b6cfb8c37ca1ec2e6b41e353
Summary: Right now systrace generates an html file that is using the Object.observe function which is now deprecated in most up to date browsers. Since we don't want to depend on the systrace being up to date, we should advise opening the trace through the Tracing tool, since that is the only way to get it working until systrace removes its dependency on Object.observe. Closes facebook#7880 Differential Revision: D3516305 Pulled By: astreet fbshipit-source-id: ab9ae46ba74b7a34b6cfb8c37ca1ec2e6b41e353
Summary: Right now systrace generates an html file that is using the Object.observe function which is now deprecated in most up to date browsers. Since we don't want to depend on the systrace being up to date, we should advise opening the trace through the Tracing tool, since that is the only way to get it working until systrace removes its dependency on Object.observe. Closes facebook/react-native#7880 Differential Revision: D3516305 Pulled By: astreet fbshipit-source-id: ab9ae46ba74b7a34b6cfb8c37ca1ec2e6b41e353
5 participants
Right now systrace generates an html file that is using the Object.observe function which is now deprecated in most up to date browsers.
Since we don't want to depend on the systrace being up to date, we should advise opening the trace through the Tracing tool, since that is the only way to get it working until systrace removes its dependency on Object.observe.