Skip to content

Conversation

@bestander
Copy link
Contributor

This should revert back to using old bridge by default until we fix gradle script to build new bridge for OSS correctly

Test Plan:

  • circle CI
  • travis
  • sandcastle

This should revert back to using old bridge by default until we fix gradle script to build new bridge for OSS correctly

Test Plan:
- circle CI
- travis
- sandcastle
@ghost
Copy link

ghost commented Jul 2, 2016

By analyzing the blame information on this pull request, we identified @foghina and @ahmedre to be potential reviewers.

@ghost ghost added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 2, 2016
@bestander
Copy link
Contributor Author

To make trunk green again I take the responsibility of approving the request.

@bestander
Copy link
Contributor Author

@facebook-github-bot shipit

@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jul 3, 2016
@ghost
Copy link

ghost commented Jul 3, 2016

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 1d86be3 Jul 3, 2016
bubblesunyum pushed a commit to iodine/react-native that referenced this pull request Aug 23, 2016
Summary:
This should revert back to using old bridge by default until we fix gradle script to build new bridge for OSS correctly
Closes facebook#8539

Differential Revision: D3514263

Pulled By: bestander

fbshipit-source-id: db9e0232b9bde27206814212dedc487c366e3511
mpretty-cyro pushed a commit to HomePass/react-native that referenced this pull request Aug 25, 2016
Summary:
This should revert back to using old bridge by default until we fix gradle script to build new bridge for OSS correctly
Closes facebook#8539

Differential Revision: D3514263

Pulled By: bestander

fbshipit-source-id: db9e0232b9bde27206814212dedc487c366e3511
tungdo194 pushed a commit to tungdo194/rn-test that referenced this pull request Apr 28, 2024
Summary:
This should revert back to using old bridge by default until we fix gradle script to build new bridge for OSS correctly
Closes facebook/react-native#8539

Differential Revision: D3514263

Pulled By: bestander

fbshipit-source-id: db9e0232b9bde27206814212dedc487c366e3511
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants