Add cardStyle prop to NavigationCardStack. #8471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the NavigationCard style to be extended, the default backgroundColor style is not applicable to all apps. Fixes issue facebook#8116. PR facebook#8115 was already made for this but didn't pass the CI checks.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
| key={'card_' + props.scene.key} | ||
| panHandlers={panHandlers} | ||
| renderScene={this.props.renderScene} | ||
| style={style} |
There was a problem hiding this comment.
property cardStyle Property not found in object type
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
CLA Signed
Member
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: This allows the `NavigationCard` style to be extended, the default `backgroundColor` style of the `NavigationCard` is not applicable to all apps. Fixes issue facebook#8116. PR facebook#8115 was already made for this but didn't pass CI checks. **Test plan** When rendering a NavigationCardStack, add ``` const { CardStack } = NavigationExperimental; ... <CardStack cardStyle={{ backgroundColor: 'purple' }} /> ``` to see that the `NavigationCard` background has changed to purple. Closes facebook#8471 Differential Revision: D3508849 Pulled By: javache fbshipit-source-id: 65703cccf3d01def9f2060256f0ff564bbdc47d3
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: This allows the `NavigationCard` style to be extended, the default `backgroundColor` style of the `NavigationCard` is not applicable to all apps. Fixes issue facebook#8116. PR facebook#8115 was already made for this but didn't pass CI checks. **Test plan** When rendering a NavigationCardStack, add ``` const { CardStack } = NavigationExperimental; ... <CardStack cardStyle={{ backgroundColor: 'purple' }} /> ``` to see that the `NavigationCard` background has changed to purple. Closes facebook#8471 Differential Revision: D3508849 Pulled By: javache fbshipit-source-id: 65703cccf3d01def9f2060256f0ff564bbdc47d3
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary:
This allows the `NavigationCard` style to be extended, the default `backgroundColor` style of the `NavigationCard` is not applicable to all apps.
Fixes issue #8116. PR #8115 was already made for this but didn't pass CI checks.
**Test plan**
When rendering a NavigationCardStack, add
```
const { CardStack } = NavigationExperimental;
...
<CardStack cardStyle={{ backgroundColor: 'purple' }} />
```
to see that the `NavigationCard` background has changed to purple.
Closes facebook/react-native#8471
Differential Revision: D3508849
Pulled By: javache
fbshipit-source-id: 65703cccf3d01def9f2060256f0ff564bbdc47d3
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the
NavigationCardstyle to be extended, the defaultbackgroundColorstyle of theNavigationCardis not applicable to all apps.Fixes issue #8116. PR #8115 was already made for this but didn't pass CI checks.
Test plan
When rendering a NavigationCardStack, add
to see that the
NavigationCardbackground has changed to purple.