Navigation card style prop #8115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @hedgerwang and @gabelevi to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
| onNavigateBack: PropTypes.func, | ||
| renderOverlay: PropTypes.func, | ||
| renderScene: PropTypes.func.isRequired, | ||
| cardStyle: React.propTypes.style, |
There was a problem hiding this comment.
property propTypes Property not found in module react
| onNavigateBack: PropTypes.func, | ||
| renderOverlay: PropTypes.func, | ||
| renderScene: PropTypes.func.isRequired, | ||
| cardStyle: React.View.propTypes.style, |
There was a problem hiding this comment.
property View Property not found in module react
stam
added a commit
to CodeYellowBV/react-native
that referenced
this pull request
Jun 28, 2016
This allows the NavigationCard style to be extended, the default backgroundColor style is not applicable to all apps. Fixes issue facebook#8116. PR facebook#8115 was already made for this but didn't pass the CI checks.
This was referenced Jun 28, 2016
Author
|
Closing in favour of #8471, which passes CI checks |
ghost
pushed a commit
that referenced
this pull request
Jul 1, 2016
Summary: This allows the `NavigationCard` style to be extended, the default `backgroundColor` style of the `NavigationCard` is not applicable to all apps. Fixes issue #8116. PR #8115 was already made for this but didn't pass CI checks. **Test plan** When rendering a NavigationCardStack, add ``` const { CardStack } = NavigationExperimental; ... <CardStack cardStyle={{ backgroundColor: 'purple' }} /> ``` to see that the `NavigationCard` background has changed to purple. Closes #8471 Differential Revision: D3508849 Pulled By: javache fbshipit-source-id: 65703cccf3d01def9f2060256f0ff564bbdc47d3
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary: This allows the `NavigationCard` style to be extended, the default `backgroundColor` style of the `NavigationCard` is not applicable to all apps. Fixes issue facebook#8116. PR facebook#8115 was already made for this but didn't pass CI checks. **Test plan** When rendering a NavigationCardStack, add ``` const { CardStack } = NavigationExperimental; ... <CardStack cardStyle={{ backgroundColor: 'purple' }} /> ``` to see that the `NavigationCard` background has changed to purple. Closes facebook#8471 Differential Revision: D3508849 Pulled By: javache fbshipit-source-id: 65703cccf3d01def9f2060256f0ff564bbdc47d3
mpretty-cyro
pushed a commit
to HomePass/react-native
that referenced
this pull request
Aug 25, 2016
Summary: This allows the `NavigationCard` style to be extended, the default `backgroundColor` style of the `NavigationCard` is not applicable to all apps. Fixes issue facebook#8116. PR facebook#8115 was already made for this but didn't pass CI checks. **Test plan** When rendering a NavigationCardStack, add ``` const { CardStack } = NavigationExperimental; ... <CardStack cardStyle={{ backgroundColor: 'purple' }} /> ``` to see that the `NavigationCard` background has changed to purple. Closes facebook#8471 Differential Revision: D3508849 Pulled By: javache fbshipit-source-id: 65703cccf3d01def9f2060256f0ff564bbdc47d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users of NavigationCardStack to override the cards’ styles. Motivated by the need to change the NavigationCard backgroundColor.