Add cardStyle prop to NavigationCardStack. #8470
Conversation
This allows the NavigationCard style to be extended, the default backgroundColor style is not applicable to all apps. Fixes issue facebook#8116. PR facebook#8115 was already made for this but didn't pass the CI checks.
|
By analyzing the blame information on this pull request, we identified @hedgerwang and @jmurzy to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
ghost
added
the
|
Closing, because CLA doesn't seem to work from my organization. |
| key={'card_' + props.scene.key} | ||
| panHandlers={panHandlers} | ||
| renderScene={this.props.renderScene} | ||
| style={style} |
There was a problem hiding this comment.
property cardStyle Property not found in object type
|
The propType check in NavigationCard for style is Proptypes.any. While in NavigationCardStack, the cardStyle is validated as View.propTypes.style. It's better to keep the type consistent to avoid unnecessary warnings. |
3 participants
This allows the
NavigationCardstyle to be extended, the defaultbackgroundColorstyle of theNavigationCardis not applicable to all apps.Fixes issue #8116. PR #8115 was already made for this but didn't pass CI checks.
Test plan
When rendering a NavigationCardStack, add
to see that the
NavigationCardbackground has changed to purple.