Initialize Kernel Library #46838
Closed
Initialize Kernel Library #46838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: rscales <[email protected]> Add initial framework for odbc dll - Add ARROW_FLIGHT_SQL_ODBC option. If we set `ARROW_FLIGHT_SQL_ODBC=ON`, the flightsql odbc folder will be built - Add odbc api layer for entry_point.cc - builds odbc dll file, with ODBC APIs exported in odbc.def Address James' comments Fix `odbcabstraction` build errors and partially fix `flightsql_odbc` errors Fix boost-variant not found error - Adding dependencies from odbc/vcpkg.json to cpp/vcpkg.json - Fix whereami.cc and .h dependency; ported lates code Update whereami.cc - use `long` instead of `int64`. Fixed namespace issues. - PR CI fix: Add `parquet-testing` back Partial build fix for `flight_sql` folder - Replaced `namespace arrow` and `namespace odbcabstraction` with `using namespace ...` - fix flight_sql_connection.cc Fix `util::nullopt` to use `std::nullopt` - fix std::optional - fix BufferReader - Fix GetSchema - fix json_converter.cc - partial fix configuration.h - partial fix get_info_cache.cc - Fix winsock build error - Comment out `flight_sql` files that cannot build - Comment out configuration and unit tests - Comment out get info cache and system trust store Create initial odbc tests folder Implement SQLAllocEnv Fix cmake build Implement SQLFreeEnv Fix rest of build errors from `flightsql-odbc` - Fix get info errors - Fix for configuration window - added odbcinst library - Fix system trust store - unit test fixes - Add dependency of ARROW_COMPUTE. `arrow/compute/api.h` is used in `flight_sql`. Adding `ARROW_COMPUTE=ON` during build fixed run time unit tests failures. Implement SQLAllocConnect and SQLFreeConnect Fix build issue from static flight sql driver Lint and code style fixes Re-add deleted submodule parquet-testing clang-format lint fix cpplint lint fix Exclude whereami in rat exclude list C++/CLI lint fix Update parquet-testing to match commit from `main` Address Kou's comments ODBC directory lint fixes Catching the lint fixes outside of `flightsql-odbc` code Fix build warnings that get treated as error Implement SQLSetEnvAttr and SQLGetEnvAttr Implement use of ExecuteWithDiagnostics Doxygen Error Fixes and Address comments from Kou and James Address comments from Kou - Updates License.txt - Update cmake toolchain - Move whereami to `vendored` - Use string_view instead of NOLINT std::string Remove `whereami.cc` from arrow util build We are building whereami.cc as part of odbc Fix include headers to replace <> with "" Address comments from James Implement SQLGetDiagField
Implement stubs for SQLGetInfo, SQLGetDiagField and SQLGetDiagRec Separate RegisterDsn and UnregisterDsn from windows build Update code to save driver value from connection string Add ReadMes for ODBC and tests Fix test issues with string_view Address code reviews Update entry_points.cc to fix build issue Remove Dremio references Use emplace properly Address comment from Rob and add SQLDisconnect test case
Accidentally committed the change during git rebase
Tests are skipped for now.
Add todo to update logging system later Add logs
* Add todo for noauth validation * mock server with token auth Add tests * run same test with both modes * Enable ODBC tests in workflow * Switch current test cases to use FlightSQLODBCTestBase So the tests can be skipped when `TEST_CONNECT_STR` is not set. * Change tests to run on both mock and remote modes Wrap usage of TEST_CONNECT_STR where possible * Rename test fixtures and make connection string functions virtual * Fix lint issue * Attempt to enable ODBC build on Windows platforms * Attempt to fix clang64 and MinGW errors * Attempt to register ODBC * Address James' comments Use constant string for token * use ServerMiddleware to validate token
PopulateCallOptions before making a connection Fix dsn window bug with advance properties Fix seg fault issue from empty string
* Let compiler append `W` to ODBC APIs where applicable.
…rs (apache#46696) ### Rationale for this change apache#45908 brought these helpers into the public API but didn't consider changes to their API. This PR makes all the helpers use the standard Result-pattern to make them more ergonomic. We can do this now without a breaking change because this and apache#45908 will be part of Arrow 21. ### What changes are included in this PR? - Refactored all FromJSONString helpers to use the Result pattern (instead of using outparams) ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46439 Lead-authored-by: Bryce Mecum <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…_test.sh (apache#46700) ### Rationale for this change `ci/scripts/cpp_test.sh` violates two shellcheck rules. * SC2071: `< is for string comparisons. Use -lt instead.` * SC2086: `Double quote to prevent globbing and word splitting.` ``` ./ci/scripts/cpp_test.sh In ./ci/scripts/cpp_test.sh line 22: if [[ $# < 2 ]]; then ^-- SC2071 (error): < is for string comparisons. Use -lt instead. In ./ci/scripts/cpp_test.sh line 87: pushd ${build_dir} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: pushd "${build_dir}" In ./ci/scripts/cpp_test.sh line 103: --parallel ${n_jobs} \ ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: --parallel "${n_jobs}" \ In ./ci/scripts/cpp_test.sh line 105: --timeout ${ARROW_CTEST_TIMEOUT:-300} \ ^-------------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: --timeout "${ARROW_CTEST_TIMEOUT:-300}" \ In ./ci/scripts/cpp_test.sh line 111: examples=$(find ${binary_output_dir} -executable -name "*example") ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: examples=$(find "${binary_output_dir}" -executable -name "*example") In ./ci/scripts/cpp_test.sh line 129: ${binary_output_dir}/arrow-ipc-stream-fuzz ${ARROW_TEST_DATA}/arrow-ipc-stream/crash-* ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${binary_output_dir}"/arrow-ipc-stream-fuzz "${ARROW_TEST_DATA}"/arrow-ipc-stream/crash-* In ./ci/scripts/cpp_test.sh line 130: ${binary_output_dir}/arrow-ipc-stream-fuzz ${ARROW_TEST_DATA}/arrow-ipc-stream/*-testcase-* ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${binary_output_dir}"/arrow-ipc-stream-fuzz "${ARROW_TEST_DATA}"/arrow-ipc-stream/*-testcase-* In ./ci/scripts/cpp_test.sh line 131: ${binary_output_dir}/arrow-ipc-file-fuzz ${ARROW_TEST_DATA}/arrow-ipc-file/*-testcase-* ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${binary_output_dir}"/arrow-ipc-file-fuzz "${ARROW_TEST_DATA}"/arrow-ipc-file/*-testcase-* In ./ci/scripts/cpp_test.sh line 132: ${binary_output_dir}/arrow-ipc-tensor-stream-fuzz ${ARROW_TEST_DATA}/arrow-ipc-tensor-stream/*-testcase-* ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${binary_output_dir}"/arrow-ipc-tensor-stream-fuzz "${ARROW_TEST_DATA}"/arrow-ipc-tensor-stream/*-testcase-* In ./ci/scripts/cpp_test.sh line 134: ${binary_output_dir}/parquet-arrow-fuzz ${ARROW_TEST_DATA}/parquet/fuzzing/*-testcase-* ^------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${binary_output_dir}"/parquet-arrow-fuzz "${ARROW_TEST_DATA}"/parquet/fuzzing/*-testcase-* For more information: https://www.shellcheck.net/wiki/SC2071 -- < is for string comparisons. Use ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ``` ### What changes are included in this PR? * Use `-lt` instead of `<` * Quote variables. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46699 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…l name to match newest auditwheel naming (apache#46705) ### Rationale for this change The new version of auditwheel has added improvements to detect libc / platform on the wheels: - pypa/auditwheel#548 This has updated the ordering of the platform tags for some of the generated wheels. For the case of our manylinux_2014 and libc 2.17 but only for Python 3.13 amd64 and 3.13t arm64. The rest are using the old order. ### What changes are included in this PR? Force the newest version and update to new order of platform tags. ### Are these changes tested? Via archery. ### Are there any user-facing changes? No * GitHub Issue: apache#46691 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change Asks users to specify language when using the kapa.ai bot ### What changes are included in this PR? Update user instructions ### Are these changes tested? Nah but I'll build the docs here to look ### Are there any user-facing changes? Yeah, the instructions Authored-by: Nic Crane <[email protected]> Signed-off-by: Nic Crane <[email protected]>
…environment in `case_when()` (apache#46667) ### Rationale for this change When a script is called in an environment that isn't the global environment (for instance with `source("my-script.R", local = new.env())`, `case_when()` would fail to detect external objects used in conditions. This PR fixes this behavior. Fixes apache#46636 ### What changes are included in this PR? When evaluating expressions in `dplyr` functions, `eval_tidy()` now takes into account `mask` as an environment where it should look for external objects. @ thisisnic suggested in apache#46636 that the bug might be due to https://github.com/apache/arrow/blob/main/r/R/dplyr-funcs-conditional.R#L116 but I couldn't find a way to fix it there. ### Are these changes tested? I added a test for this scenario. I ensured it failed before the change and succeeds after. ### Are there any user-facing changes? There is one user-facing, non-breaking change, illustrated both in the related issue and in the new test. * GitHub Issue: apache#46636 Authored-by: etiennebacher <[email protected]> Signed-off-by: Nic Crane <[email protected]>
…l function (apache#46722) ### Rationale for this change pkgdown generation was failing due to a function not being included in the list of functions to document ### What changes are included in this PR? Update roxygen header to not generate that function or trigger the pkgdown check ### Are these changes tested? Nah, but I'll trigger CI to check ### Are there any user-facing changes? No * GitHub Issue: apache#46717 Authored-by: Nic Crane <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…rdBatchReader (apache#46731) ### Rationale for this change Our docs say you can construct a Dataset from a RecordBatchReader but you can't. While we can't pass the actual RecordBatchReader to the Dataset as a source (AFAIK), we can at least consume the reader immediately and create an InMemoryDataset from the batches. ### What changes are included in this PR? - Tweaked type checks so this now works (both from ds.dataset and ds.InMemoryDataset) - Test case extended to cover the new behavior - Tweaked error message just to use proper case ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46729 Authored-by: Bryce Mecum <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>
…ache#46142) ### Rationale for this change Continues building out support for Meson as a build system generator ### What changes are included in this PR? This adds the flight directory to the Meson configuration ### Are these changes tested? Locally ### Are there any user-facing changes? No * GitHub Issue: apache#46141 Authored-by: Will Ayd <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
… arrow::ArrayStatistics::Equals() (apache#46422) ### Rationale for this change `arrow::ArrayStatistics::Equals` does not handle double values for `ArrayStatistics::ValueType` correctly ### What changes are included in this PR? Add `arrow::EqualOptions` to `arrow::ArrayStatistics::Eqauls()` Add `arrow::ArrayStatisticsEqauls()` Add `EqualOptions::use_atol_` Add `EqualOptions::use_atol()` Add `EqualOptions::use_atol(bool v)` ### Are these changes tested? Yes, I ran the relevant unit tests. ### Are there any user-facing changes? Yes. Add `arrow::ArrayStatisticsEqauls()` Add `EqualOptions::use_atol()` Add `EqualOptions::use_atol(bool v)` * GitHub Issue: apache#46395 Authored-by: Arash Andishgar <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…6721) ### Rationale for this change Historically, we've been lax about selecting which APIs are public. A lot of internal APIs are exposed publicly. ### What changes are included in this PR? Make some headers in `arrow/util` internal. They won't be installed and so won't be available for third-party usage. Note that this represents a subset of all internal APIs in `arrow/util`, as some of them are included in other public headers. ### Are these changes tested? Yes, by existing CI configurations. ### Are there any user-facing changes? Unless the user was relying on internal APIs, there should not be any change. * GitHub Issue: apache#46459 Lead-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
…pache#46626) ### Rationale for this change Arrow deals with secrets like encryption / decryption keys which must be kept private. One way of leaking such secrets is through memory allocation where another process allocates memory that previously hold the secret, because that memory was not cleared before being freed. ### What changes are included in this PR? Uses various implementations of securely clearing memory, notably - `SecureZeroMemory`(Windows) - `memset_s`(STDC) - `OPENSSL_cleanse` (OpenSSL >= 3) - `explicit_bzero`(glibc 2.25+) - volatile `memset` (fallback). ### Are these changes tested? Unit tests. ### Are there any user-facing changes? This only adds the `SecureString` class and tests. Using this new infrastructure is done in follow-up pull requests. * GitHub Issue: apache#31603 Lead-authored-by: Enrico Minack <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
### Rationale for this change PR apache#46408 included a typo that changed list-view IPC tests to use the same data as list tests. This was detected as a duplicate corpus file by the OSS-Fuzz CI build. ### What changes are included in this PR? Undo mistake that led to using the same test data for lists and list-views. Also fix a regression in the CUDA tests, due to reading non-CPU memory when fetching the first offset in a list/binary array. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46704 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
### Rationale for this change We can use pre-commit instead of "archery lint" for all linters/formatters. ### What changes are included in this PR? * Remove "archery lint" CI job * Remove "archery lint" related codes including IWYU and clang-tidy because IWYU and clang-tidy aren't used for now * Remove "archery lint" related docs including IWYU and clang-tidy related docs ### Are these changes tested? Yes. ### Are there any user-facing changes? No. It's only affected to developers. * GitHub Issue: apache#46528 Lead-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Bryce Mecum <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…6799) ### Rationale for this change Ubuntu 22.04 ships pre-commit 2.17.0. So we should support pre-commit 2.17.0 for easy to develop. ### What changes are included in this PR? * Use a bit older shfmt pre-commit configuration for pre-commit 2.17.0 * Use Ubuntu 22.04 on CI to ensure working on Ubuntu 22.04 ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46798 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…red library (apache#46261) ### Rationale for this change Arrow is quite a heavy dependency and some users don't need all the tools we provide bundled with libarrow. Moving Arrow Compute to its own shared library allows users installations that better suit their needs having smaller memory footprint if necessary. It might also help some users adding new kernels into an existing Arrow without recompiling it. ### What changes are included in this PR? - Move all the Arrow Compute kernel functions to a new `ArrowCompute` shared library (`libarrow_compute.so`). - Create a new API to Initialize arrow compute registering the existing Kernels into the `FunctionRegistry` - Update Python/R/CGLib bindings to automatically register the Compute kernels transparently to the user. - Update Linux Packaging to provide the new arrow-compute library. - Update documentation with new requirements to call `arrow::compute::Initialize()` ### Are these changes tested? Yes on all CI jobs. ### Are there any user-facing changes? Yes. The Arrow compute functions will be provided as a different library. Any user using Arrow Compute from C++ directly will require a call to `arrow::compute::Initialize()` in order for the functions and kernels to be registered **This PR includes breaking changes to public APIs.** * GitHub Issue: apache#25025 Lead-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Bryce Mecum <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Co-authored-by: Rossi Sun <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
…t on some config files (apache#46802) ### Rationale for this change The config for Java, Go, JS and Swift on those files is not relevant anymore. ### What changes are included in this PR? Remove references for those implementations from labeler, codeowners and editorconfig files. ### Are these changes tested? No ### Are there any user-facing changes? No * GitHub Issue: apache#46801 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
… after migration to new repository (apache#46804) ### Rationale for this change The Swift implementation has been moved to their own repository at https://github.com/apache/arrow-swift ### What changes are included in this PR? Remove `swift/` subfolder and github workflow for CI job. ### Are these changes tested? No ### Are there any user-facing changes? No but for developers of the swift implementation it has been moved to their own repository. * GitHub Issue: apache#46803 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Closes apache#46775 and apache#46782. This also adds external link icons beside the docs links in the Implementations table that link to docs pages outside of the main repo Sphinx docs. * GitHub Issue: apache#46775
…e#46807) ### Rationale for this change apache#46803 Removed switch implementation. But, Some Swift relate files are still exists. ### What changes are included in this PR? Remove Swift related settings ### Are these changes tested? No. ### Are there any user-facing changes? No but for developers of the swift implementation it has been moved to their own repository. * GitHub Issue: apache#46806 Authored-by: Hiroyuki Sato <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…#46812) ### Rationale for this change The lint job is failing, because of the R hooks missing packages. This happens because the library of the environment symlinks the R packages from the separate `renv` cache in `.local`. ### What changes are included in this PR? - also cache renv cache - only install r-base (saves ~30s) as we need to install all required packages through renv anyway ### Are these changes tested? CI ### Are there any user-facing changes? CI no longer ❌ * GitHub Issue: apache#46805 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Closes apache#46816 * GitHub Issue: apache#46816
…/compu… (apache#46810) ### Rationale for this change The PR to split the Arrow compute kernels into its own shared library had some headers at arrow/compute/kernels during development. Those were moved to arrow/compute on this commit: apache@1d90aeb We missed to update the RPM packages in the interim as there are no public headers to be installed anymore from `arrow/compute/kernels` ### What changes are included in this PR? Stop trying to include or exclude `/arrow/compute/kernels` headers on RPM package ### Are these changes tested? Yes, via archery ### Are there any user-facing changes? No * GitHub Issue: apache#46809 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…ache#46758) ### Rationale for this change Apache Arrow 19.0.1 available in the conan repository. Need synchronize upstream. ### What changes are included in this PR? * execute `ci/conan/merge_upstream.sh` * Resolve merge failed files. (Both files contains license headers. So patch failed) * `ci/conan/all/test_package/CMakeLists.txt` * `ci/conan/all/conanfile.py` ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46757 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…6821) ### Rationale for this change We're using `NODE=XX` in `.env` as the default Node.js version. ### What changes are included in this PR? Use `NODE=20` in `.env`. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#46820 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
### Rationale for this change 32 and 64 bit Decimal types were added in C++ in apache#43957 but haven't been implemented in R yet ### What changes are included in this PR? Implements them in R ### Are these changes tested? Yup ### Are there any user-facing changes? Yeah, new types but also the implicit downcasting so we should think about how to communicate this if at all * GitHub Issue: apache#46719 Authored-by: Nic Crane <[email protected]> Signed-off-by: Nic Crane <[email protected]>
### Rationale for this change GLib should be able to use `arrow::FixedSizeListType`. ### What changes are included in this PR? Add `GArrowFixedSizeListDataType`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#46773 Lead-authored-by: Hiroyuki Sato <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…che#45306) ### Rationale for this change The current bundled version 1.10.55 was released on 2023-01-20: https://github.com/aws/aws-sdk-cpp/releases/tag/1.10.55 ### What changes are included in this PR? * Use the latest AWS SDK for C++ * Migrate to FetchContent from ExternalProject ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#45195 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…extension types by default (apache#46772) ### Rationale for this change The Parquet C++ implementation now supports reading four logical types (JSON, UUID, Geometry, Geography) as Arrow extension types; however, users have to opt-in to avoid loosing the logical type on read. ### What changes are included in this PR? This PR sets the default value of `arrow_extensions_enabled` to `True` (in Python). ### Are these changes tested? Yes, the behaviour of `arrow_extensions_enabled` was already tested (and tests were updated to reflect the new default value). ### Are there any user-facing changes? **This PR includes breaking changes to public APIs.** Reading Parquet files that contained a JSON or UUID logical type will now have an extension type rather than string or fixed size binary, respectively. Python users that were relying on the previous behaviour would have to explicitly cast to storage or use `read_table(..., arrow_extensions_enabled=False)` after this PR: ```python import uuid import pyarrow as pa json_array = pa.array(['{"k": "v"}'], pa.json_()) json_array.cast(pa.string()) #> [ #> "{"k": "v"}" #> ] uuid_array = pa.array([uuid.uuid4().bytes], pa.uuid()) uuid_array.cast(pa.binary(16)) #> <pyarrow.lib.FixedSizeBinaryArray object at 0x11e42b1c0> #> [ #> 746C1022AB434A97972E1707EC3EE8F4 #> ] ``` * GitHub Issue: apache#44500 Authored-by: Dewey Dunnington <[email protected]> Signed-off-by: AlenkaF <[email protected]>
As per changes from apache#46261, we need to initialize Kernel library explicitly to get the functions registered
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
Contributor
Author
|
Omg sorry, I used the wrong target branch, closing the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per changes from #46261, we need to initialize Kernel library explicitly to get the functions registered.
Same as #50 except I wanted to fix the branch names.