GH-46805: [CI][Dev] Fix caching for R hooks in lint job #46812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The current run is a re-run with cache hit 🎉 |
kou
approved these changes
Jun 14, 2025
| sudo apt install -y -V \ | ||
| pre-commit \ | ||
| r-cran-xml2 \ | ||
| r-base \ |
github-actions
bot
added
awaiting review
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c5d192b. There were 118 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
alinaliBQ
pushed a commit
to Bit-Quill/arrow
that referenced
this pull request
Jun 17, 2025
…#46812) ### Rationale for this change The lint job is failing, because of the R hooks missing packages. This happens because the library of the environment symlinks the R packages from the separate `renv` cache in `.local`. ### What changes are included in this PR? - also cache renv cache - only install r-base (saves ~30s) as we need to install all required packages through renv anyway ### Are these changes tested? CI ### Are there any user-facing changes? CI no longer ❌ * GitHub Issue: apache#46805 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The lint job is failing, because of the R hooks missing packages. This happens because the library of the environment symlinks the R packages from the separate
renvcache in.local.What changes are included in this PR?
Are these changes tested?
CI
Are there any user-facing changes?
CI no longer ❌