GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.587 #45306

kou · 2025-01-20T08:31:00Z

Rationale for this change

The current bundled version 1.10.55 was released on 2023-01-20:
https://github.com/aws/aws-sdk-cpp/releases/tag/1.10.55

What changes are included in this PR?

Use the latest AWS SDK for C++
Migrate to FetchContent from ExternalProject

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

GitHub Issue: [C++] Update bundled AWS SDK for C++ from 1.10.55 #45195

kou · 2025-01-20T08:31:22Z

@github-actions crossbow submit -g cpp -g r

github-actions · 2025-01-20T08:31:25Z

⚠️ GitHub issue #45195 has been automatically assigned in GitHub to PR creator.

h-vetinari · 2025-01-20T08:49:38Z

From the POV of the update for #45195, please don't go past 1.1.458 for now, see #45304

kou · 2025-01-20T09:12:54Z

Thanks for the tip! I saw your comment in #45195 but I wanted to try the latest version as the first try. :-)

please don't go past 1.1.458 for now

It's 1."10".458, right?

h-vetinari · 2025-01-20T09:23:21Z

please don't go past 1.1.458 for now

It's 1."10".458, right?

Sorry for the typo, it's 1."11".458

h-vetinari · 2025-01-23T09:57:10Z

cpp/thirdparty/versions.txt

PR title needs an update; 1.11.488 -> 1.11.489 ;-)

Good catch!

kou · 2025-01-27T07:22:22Z

@github-actions crossbow submit -g cpp -g wheel -g r -g linux

kou · 2025-01-27T08:08:18Z

@github-actions crossbow submit ubuntu-jammy-amd64

pitrou · 2025-01-27T16:49:36Z

cpp/thirdparty/README.md

This is neat, but the path doesn't look right, should be cpp/thirdparty/update.rb?

Oh... Good catch! You're right.

pitrou · 2025-01-27T16:50:50Z

cpp/thirdparty/update.rb

Is it possible to have a -h/--help option to display usage?

Yes. I'll add it.

kou · 2025-01-28T20:13:05Z

@github-actions crossbow submit r-binary-packages

It's referred from aws-sdk-cpp.

kou · 2025-06-16T00:34:14Z

I'll merge this in a few days if nobody objects it.

raulcd · 2025-06-16T07:49:59Z

cpp/cmake_modules/ThirdpartyToolchain.cmake

 if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.28)
  list(APPEND FC_DECLARE_COMMON_OPTIONS EXCLUDE_FROM_ALL TRUE)
 endif()
+if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.25)


won't this always be true with our CMake minimum required version?

Good catch! I'll remove this check.

raulcd · 2025-06-16T07:54:06Z

This is a great amount of work. Thanks @kou for doing that!

kou · 2025-06-17T02:04:35Z

I'll merge this.

kou · 2025-06-17T02:09:48Z

#46832 is for the UWSGI crash.

conbench-apache-arrow · 2025-06-17T10:48:46Z

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 7cf158a.

There were 119 benchmark results with an error:

Commit Run on arm64-t4g-2xlarge-linux at 2025-06-17 02:58:16Z
- tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-07, scale_factor=1
- tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-09, scale_factor=1
and 117 more (see the report linked below)

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

…che#45306) ### Rationale for this change The current bundled version 1.10.55 was released on 2023-01-20: https://github.com/aws/aws-sdk-cpp/releases/tag/1.10.55 ### What changes are included in this PR? * Use the latest AWS SDK for C++ * Migrate to FetchContent from ExternalProject ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#45195 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…uffix (#46967) ### Rationale for this change Conan uses upper case for config suffix: https://github.com/conan-io/conan/blob/3bc93e28d46f071da45d11f5256c6af52404b756/conan/tools/cmake/cmakedeps/templates/__init__.py#L69 #45306 stopped upcasing configuration name. So `$<CONFIG>` may not upper case. ### What changes are included in this PR? Ensure using upper case configuration name for Conan bzip2 target. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #46964 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

github-actions bot added Component: C++ awaiting committer review Awaiting committer review labels Jan 20, 2025

This comment was marked as outdated.

Sign in to view

kou force-pushed the cpp-bundled-aws-sdk-cpp branch from f0dcc60 to b41b663 Compare January 22, 2025 00:54

github-actions bot added the Component: Documentation label Jan 22, 2025

h-vetinari reviewed Jan 23, 2025

View reviewed changes

kou changed the title ~~GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.488~~ GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.489 Jan 23, 2025

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting committer review Awaiting committer review awaiting changes Awaiting changes labels Jan 23, 2025

This comment was marked as outdated.

Sign in to view

kou mentioned this pull request Jan 27, 2025

[R] Can we bump MACOSX_DEPLOYMENT_TARGET from 10.13? #45356

Closed

This comment was marked as outdated.

Sign in to view

pitrou reviewed Jan 27, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes awaiting change review Awaiting change review and removed awaiting change review Awaiting change review awaiting changes Awaiting changes labels Jan 27, 2025

kou force-pushed the cpp-bundled-aws-sdk-cpp branch from fbcb205 to a090a31 Compare January 28, 2025 20:11

This comment was marked as outdated.

Sign in to view

kou added 8 commits June 16, 2025 09:33

Don't change CMAKE_BUILD_TYPE

022543f

It's referred from aws-sdk-cpp.

Don't use cache variable as much as possible

0217dc0

Use the same curl

43d40b3

Don't install aws-sdk-cpp

62209d4

Update versions

c1642d8

Skip uwsgi test

7e77f8a

Use function for LZ4

108ecb1

Remove needless curl

bffd579

kou force-pushed the cpp-bundled-aws-sdk-cpp branch from e88c0fe to bffd579 Compare June 16, 2025 00:34

raulcd reviewed Jun 16, 2025

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 16, 2025

Remove a needless version check

1007963

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 16, 2025

kou merged commit 7cf158a into apache:main Jun 17, 2025
33 checks passed

kou deleted the cpp-bundled-aws-sdk-cpp branch June 17, 2025 02:04

kou removed the awaiting change review Awaiting change review label Jun 17, 2025

kou mentioned this pull request Jun 17, 2025

[Python] UWSGI test is crashed with AWS SDK C++ for C++ 1.11.587 #46832

Open

kou mentioned this pull request Jun 19, 2025

GH-46740: [C++] Update bundled Thrift to 0.22.0 #46741

Closed

This was referenced Jul 2, 2025

GH-46968: [CI][Packaging] Synchronize conan files for 20.0.0 #46966

Merged

GH-46964: [CI][Packaging][Conan] Ensure using upper case for config suffix #46967

Merged

[CI][Packaging] conan-maximum is failing #46964

Closed

GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.587 #45306

GH-45195: [C++] Update bundled AWS SDK for C++ to 1.11.587 #45306

Uh oh!

Conversation

kou commented Jan 20, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

kou commented Jan 20, 2025

Uh oh!

github-actions bot commented Jan 20, 2025

Uh oh!

This comment was marked as outdated.

h-vetinari commented Jan 20, 2025

Uh oh!

kou commented Jan 20, 2025

Uh oh!

h-vetinari commented Jan 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kou commented Jan 27, 2025

Uh oh!

This comment was marked as outdated.

kou commented Jan 27, 2025

Uh oh!

This comment was marked as outdated.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kou commented Jan 28, 2025

Uh oh!

This comment was marked as outdated.

kou commented Jun 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

raulcd commented Jun 16, 2025

Uh oh!

kou commented Jun 17, 2025

Uh oh!

Uh oh!

kou commented Jun 17, 2025

Uh oh!

conbench-apache-arrow bot commented Jun 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kou commented Jan 20, 2025 •

edited by github-actions bot

Loading