Skip to content

Conversation

@kou
Copy link
Member

@kou kou commented Jul 2, 2025

Rationale for this change

Conan uses upper case for config suffix: https://github.com/conan-io/conan/blob/3bc93e28d46f071da45d11f5256c6af52404b756/conan/tools/cmake/cmakedeps/templates/__init__.py#L69

#45306 stopped upcasing configuration name. So $<CONFIG> may not upper case.

What changes are included in this PR?

Ensure using upper case configuration name for Conan bzip2 target.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
Copy link
Member Author

kou commented Jul 2, 2025

@github-actions crossbow submit -g conan

@kou kou marked this pull request as ready for review July 2, 2025 02:28
@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jul 2, 2025
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Revision: 80ae88c

Submitted crossbow builds: ursacomputing/crossbow @ actions-e5df37694c

Task Status
conan-maximum GitHub Actions
conan-minimum GitHub Actions

Copy link
Member Author

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jul 2, 2025
@kou kou merged commit 33c8de7 into apache:main Jul 2, 2025
35 checks passed
@kou kou removed the awaiting changes Awaiting changes label Jul 2, 2025
@kou kou deleted the conan-config branch July 2, 2025 04:34
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 33c8de7.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant