Skip to content

Conversation

@WillAyd
Copy link
Contributor

@WillAyd WillAyd commented Apr 14, 2025

Rationale for this change

Continues building out support for Meson as a build system generator

What changes are included in this PR?

This adds the flight directory to the Meson configuration

Are these changes tested?

Locally

Are there any user-facing changes?

No

@WillAyd WillAyd requested a review from lidavidm as a code owner April 14, 2025 20:46
@github-actions
Copy link

⚠️ GitHub issue #46141 has been automatically assigned in GitHub to PR creator.

@WillAyd WillAyd force-pushed the meson-flight-directory branch 2 times, most recently from e88300c to eddb36a Compare April 14, 2025 20:53
cpp/meson.build Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bumped this to C11 as that is what the CMake configuration uses, but it also appears that the c-ares dependency requires some POSIX extensions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namely it appears that c-ares wants to include macros from <net/if.h> and looks for macros like CLOCK_MONOTONIC from time.h on non-windows platforms

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Apr 14, 2025
@WillAyd WillAyd force-pushed the meson-flight-directory branch from eddb36a to 97138b8 Compare April 14, 2025 21:08
@WillAyd
Copy link
Contributor Author

WillAyd commented Apr 14, 2025

I am not very familiar with Flight so apologies for any oversights, but I think this is a reasonable translation of the CMakeLists.txt

@WillAyd
Copy link
Contributor Author

WillAyd commented Apr 14, 2025

@github-actions crossbow submit *meson

@github-actions
Copy link

Revision: 97138b8355543dc8375756c04167683bd3529d1d

Submitted crossbow builds: ursacomputing/crossbow @ actions-9b43f97786

Task Status
test-conda-cpp-meson GitHub Actions

@WillAyd WillAyd force-pushed the meson-flight-directory branch from 97138b8 to 56cec4d Compare April 15, 2025 03:34
@WillAyd WillAyd force-pushed the meson-flight-directory branch from 56cec4d to 101f900 Compare April 23, 2025 12:51
@WillAyd WillAyd force-pushed the meson-flight-directory branch from 101f900 to 6bc0d6c Compare May 7, 2025 16:41
@WillAyd
Copy link
Contributor Author

WillAyd commented May 7, 2025

@github-actions crossbow submit *meson

@github-actions
Copy link

github-actions bot commented May 7, 2025

Revision: 6bc0d6cf784a6c504f17efb443edb756322e1dfa

Submitted crossbow builds: ursacomputing/crossbow @ actions-fb9cb3520d

Task Status
test-conda-cpp-meson GitHub Actions

@WillAyd WillAyd force-pushed the meson-flight-directory branch from 6bc0d6c to b3852cf Compare May 7, 2025 17:11
@WillAyd
Copy link
Contributor Author

WillAyd commented May 7, 2025

@github-actions crossbow submit *meson

@github-actions
Copy link

github-actions bot commented May 7, 2025

Revision: b3852cf97711d680d1f8c92b397848b0b6a190e6

Submitted crossbow builds: ursacomputing/crossbow @ actions-eca4b34981

Task Status
test-conda-cpp-meson GitHub Actions

@WillAyd WillAyd force-pushed the meson-flight-directory branch from b3852cf to 1d99f74 Compare May 9, 2025 21:43
@WillAyd
Copy link
Contributor Author

WillAyd commented May 9, 2025

@github-actions crossbow submit *meson

@github-actions
Copy link

github-actions bot commented May 9, 2025

Revision: 1d99f74832366fcc97d05b53f755d01b59a129ee

Submitted crossbow builds: ursacomputing/crossbow @ actions-40712c0212

Task Status
test-conda-cpp-meson GitHub Actions

@WillAyd WillAyd added the CI: Extra Run extra CI label May 30, 2025
@WillAyd WillAyd force-pushed the meson-flight-directory branch 3 times, most recently from e78ac5c to 2998b96 Compare May 30, 2025 16:40
@WillAyd
Copy link
Contributor Author

WillAyd commented May 30, 2025

@kou if you have the time to look at this one it would be appreciated. No rush - thanks as always!

@kou kou changed the title GH-46141: Add flight directory to Meson configuration GH-46141: [C++] Add flight directory to Meson configuration May 31, 2025
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 31, 2025
@WillAyd WillAyd force-pushed the meson-flight-directory branch from 2998b96 to 54987a4 Compare June 6, 2025 15:15
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 6, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 1d169cc into apache:main Jun 6, 2025
37 of 39 checks passed
@kou kou removed the awaiting change review Awaiting change review label Jun 6, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 6, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1d169cc.

There were 67 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them.

alinaliBQ pushed a commit to Bit-Quill/arrow that referenced this pull request Jun 17, 2025
…ache#46142)

### Rationale for this change

Continues building out support for Meson as a build system generator

### What changes are included in this PR?

This adds the flight directory to the Meson configuration

### Are these changes tested?

Locally

### Are there any user-facing changes?

No

* GitHub Issue: apache#46141

Authored-by: Will Ayd <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants