-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-46141: [C++] Add flight directory to Meson configuration #46142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
e88300c to
eddb36a
Compare
cpp/meson.build
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bumped this to C11 as that is what the CMake configuration uses, but it also appears that the c-ares dependency requires some POSIX extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namely it appears that c-ares wants to include macros from <net/if.h> and looks for macros like CLOCK_MONOTONIC from time.h on non-windows platforms
eddb36a to
97138b8
Compare
|
I am not very familiar with Flight so apologies for any oversights, but I think this is a reasonable translation of the CMakeLists.txt |
|
@github-actions crossbow submit *meson |
|
Revision: 97138b8355543dc8375756c04167683bd3529d1d Submitted crossbow builds: ursacomputing/crossbow @ actions-9b43f97786
|
97138b8 to
56cec4d
Compare
56cec4d to
101f900
Compare
101f900 to
6bc0d6c
Compare
|
@github-actions crossbow submit *meson |
|
Revision: 6bc0d6cf784a6c504f17efb443edb756322e1dfa Submitted crossbow builds: ursacomputing/crossbow @ actions-fb9cb3520d
|
6bc0d6c to
b3852cf
Compare
|
@github-actions crossbow submit *meson |
|
Revision: b3852cf97711d680d1f8c92b397848b0b6a190e6 Submitted crossbow builds: ursacomputing/crossbow @ actions-eca4b34981
|
b3852cf to
1d99f74
Compare
|
@github-actions crossbow submit *meson |
|
Revision: 1d99f74832366fcc97d05b53f755d01b59a129ee Submitted crossbow builds: ursacomputing/crossbow @ actions-40712c0212
|
e78ac5c to
2998b96
Compare
|
@kou if you have the time to look at this one it would be appreciated. No rush - thanks as always! |
2998b96 to
54987a4
Compare
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1d169cc. There were 67 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ache#46142) ### Rationale for this change Continues building out support for Meson as a build system generator ### What changes are included in this PR? This adds the flight directory to the Meson configuration ### Are these changes tested? Locally ### Are there any user-facing changes? No * GitHub Issue: apache#46141 Authored-by: Will Ayd <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
Continues building out support for Meson as a build system generator
What changes are included in this PR?
This adds the flight directory to the Meson configuration
Are these changes tested?
Locally
Are there any user-facing changes?
No