Skip to content

Conversation

@raulcd
Copy link
Member

@raulcd raulcd commented Jun 13, 2025

Rationale for this change

The PR to split the Arrow compute kernels into its own shared library had some headers at arrow/compute/kernels during development. Those were moved to arrow/compute on this commit:
1d90aeb

We missed to update the RPM packages in the interim as there are no public headers to be installed anymore from arrow/compute/kernels

What changes are included in this PR?

Stop trying to include or exclude /arrow/compute/kernels headers on RPM package

Are these changes tested?

Yes, via archery

Are there any user-facing changes?

No

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jun 13, 2025
@raulcd
Copy link
Member Author

raulcd commented Jun 13, 2025

@github-actions crossbow submit almalinux-8-amd64

@github-actions
Copy link

Revision: d231829

Submitted crossbow builds: ursacomputing/crossbow @ actions-cae580291f

Task Status
almalinux-8-amd64 GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jun 13, 2025

@github-actions crossbow submit almalinux-* centos-* amazon-linux-*

@raulcd raulcd marked this pull request as ready for review June 13, 2025 17:36
@github-actions
Copy link

Revision: d231829

Submitted crossbow builds: ursacomputing/crossbow @ actions-e259729c6c

Task Status
almalinux-8-amd64 GitHub Actions
almalinux-8-arm64 GitHub Actions
almalinux-9-amd64 GitHub Actions
almalinux-9-arm64 GitHub Actions
amazon-linux-2023-amd64 GitHub Actions
amazon-linux-2023-arm64 GitHub Actions
centos-7-amd64 GitHub Actions
centos-8-stream-amd64 GitHub Actions
centos-8-stream-arm64 GitHub Actions
centos-9-stream-amd64 GitHub Actions
centos-9-stream-arm64 GitHub Actions

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

arrow_install_all_headers() still exists in cpp/src/arrow/compute/kernels/CMakeLists.txt:

arrow_install_all_headers("arrow/compute/kernels")

But there are no non-internal headers in cpp/src/arrow/compute/kernels/. So $PREFIX/include/arrow/compute/kernels/ doesn't exist.

@kou kou merged commit 7c56183 into apache:main Jun 15, 2025
11 of 12 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Jun 15, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jun 15, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 7c56183.

There were 119 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

alinaliBQ pushed a commit to Bit-Quill/arrow that referenced this pull request Jun 17, 2025
…/compu… (apache#46810)

### Rationale for this change

The PR to split the Arrow compute kernels into its own shared library had some headers at arrow/compute/kernels during development. Those were moved to arrow/compute on this commit:
apache@1d90aeb

We missed to update the RPM packages in the interim as there are no public headers to be installed anymore from `arrow/compute/kernels`

### What changes are included in this PR?

Stop trying to include or exclude `/arrow/compute/kernels` headers on RPM package

### Are these changes tested?

Yes, via archery

### Are there any user-facing changes?

No

* GitHub Issue: apache#46809

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge Awaiting merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants