-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-46809: [CI][Packaging] Stop trying to add headers from arrow/compu… #46810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…/compute/kernels on rpm packages
|
@github-actions crossbow submit almalinux-8-amd64 |
|
Revision: d231829 Submitted crossbow builds: ursacomputing/crossbow @ actions-cae580291f
|
|
@github-actions crossbow submit almalinux-* centos-* amazon-linux-* |
|
Revision: d231829 Submitted crossbow builds: ursacomputing/crossbow @ actions-e259729c6c |
assignUser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
arrow_install_all_headers() still exists in cpp/src/arrow/compute/kernels/CMakeLists.txt:
| arrow_install_all_headers("arrow/compute/kernels") |
But there are no non-internal headers in cpp/src/arrow/compute/kernels/. So $PREFIX/include/arrow/compute/kernels/ doesn't exist.
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 7c56183. There were 119 benchmark results with an error:
There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…/compu… (apache#46810) ### Rationale for this change The PR to split the Arrow compute kernels into its own shared library had some headers at arrow/compute/kernels during development. Those were moved to arrow/compute on this commit: apache@1d90aeb We missed to update the RPM packages in the interim as there are no public headers to be installed anymore from `arrow/compute/kernels` ### What changes are included in this PR? Stop trying to include or exclude `/arrow/compute/kernels` headers on RPM package ### Are these changes tested? Yes, via archery ### Are there any user-facing changes? No * GitHub Issue: apache#46809 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
The PR to split the Arrow compute kernels into its own shared library had some headers at arrow/compute/kernels during development. Those were moved to arrow/compute on this commit:
1d90aeb
We missed to update the RPM packages in the interim as there are no public headers to be installed anymore from
arrow/compute/kernelsWhat changes are included in this PR?
Stop trying to include or exclude
/arrow/compute/kernelsheaders on RPM packageAre these changes tested?
Yes, via archery
Are there any user-facing changes?
No