Skip to content

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Jun 5, 2025

Rationale for this change

pkgdown generation was failing due to a function not being included in the list of functions to document

What changes are included in this PR?

Update roxygen header to not generate that function or trigger the pkgdown check

Are these changes tested?

Nah, but I'll trigger CI to check

Are there any user-facing changes?

No

@thisisnic thisisnic requested a review from jonkeane as a code owner June 5, 2025 14:45
@github-actions github-actions bot added Component: R awaiting committer review Awaiting committer review labels Jun 5, 2025
@thisisnic
Copy link
Member Author

@github-actions crossbow submit preview-docs

@github-actions
Copy link

github-actions bot commented Jun 5, 2025

Revision: f16b6a4

Submitted crossbow builds: ursacomputing/crossbow @ actions-209e5950e2

Task Status
preview-docs GitHub Actions

@kou kou changed the title GH-46717: [R][Docs] pkgdown generation is failing GH-46717: [R][Docs] Add missing "internal" keywords for internal function Jun 6, 2025
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Jun 6, 2025
@kou kou merged commit 5a52916 into apache:main Jun 6, 2025
10 of 11 checks passed
@kou kou removed the awaiting merge Awaiting merge label Jun 6, 2025
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5a52916.

There were 69 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

alinaliBQ pushed a commit to Bit-Quill/arrow that referenced this pull request Jun 17, 2025
…l function (apache#46722)

### Rationale for this change

pkgdown generation was failing due to a function not being included in the list of functions to document

### What changes are included in this PR?

Update roxygen header to not generate that function or trigger the pkgdown check

### Are these changes tested?

Nah, but I'll trigger CI to check

### Are there any user-facing changes?

No
* GitHub Issue: apache#46717

Authored-by: Nic Crane <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants