ARROW-6337: [R] Changed as_tible to as_dataframe in the R package

[jameslamb]

See ARROW-6337 for background on this PR.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@6d4f257). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5399   +/-   ##
=========================================
  Coverage          ?   76.09%           
=========================================
  Files             ?       56           
  Lines             ?     3572           
  Branches          ?        0           
=========================================
  Hits              ?     2718           
  Misses            ?      854           
  Partials          ?        0

Impacted Files	Coverage Δ
r/R/feather.R	63.33% <100%> (ø)
r/R/csv.R	100% <100%> (ø)
r/R/json.R	100% <100%> (ø)
r/R/parquet.R	66.66% <100%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4f257...66137bb. Read the comment docs.

[nealrichardson]

Acknowledging that naming things is hard, I'm not a fan of as_dataframe. That doesn't look right to me. I'd prefer as_data_frame, or even data_frame is better IMO--I'm not sure "as" adds any value.

What do you think?

[jameslamb]

Acknowledging that naming things is hard, I'm not a fan of as_dataframe. That doesn't look right to me. I'd prefer as_data_frame, or even data_frame is better IMO--I'm not sure "as" adds any value.

What do you think?

IMO as_data_frame or return_data_frame is more informative than data_frame, so it's obvious in code that it isn't, for example, a flag used to allow you to pass in parse_options as a data frame instead of named list or something.

As long as we're keeping the "change output type with a flag" pattern, my preferences in order are:

1. as_data_frame
2. return_data_frame
3. data_frame

I hold that opinion lightly though, and I'll defer to whatever you think is best on this one. Let me know what you'd like to do and I'd be happy to update the PR today!

[nealrichardson]

Alright, then as_data_frame seems to be the compromise solution. Let's go with that.

[jameslamb]

Alright, then as_data_frame seems to be the compromise solution. Let's go with that.

🤝 updated to as_data_frame and rebased to most recent master

[nealrichardson]

+1, thanks!