Skip to content

Conversation

@dragosmg
Copy link
Contributor

The ym(), my() and yq() bindings will make the following possible (and identical):

library(arrow, warn.conflicts = FALSE)
library(dplyr, warn.conflicts = FALSE)
library(lubridate, warn.conflicts = FALSE)

test_df <- tibble::tibble(
  ym_string = c("2022-05", "2022/02", "22.03", NA)
)

test_df %>% 
  mutate(ym_date = ym(ym_string))
#> # A tibble: 4 × 2
#>   ym_string ym_date   
#>   <chr>     <date>    
#> 1 2022-05   2022-05-01
#> 2 2022/02   2022-02-01
#> 3 22.03     2022-03-01
#> 4 <NA>      NA

test_df %>% 
  arrow_table() %>% 
  mutate(ym_date = ym(ym_string)) %>% 
  collect()
#> # A tibble: 4 × 2
#>   ym_string ym_date   
#>   <chr>     <date>    
#> 1 2022-05   2022-05-01
#> 2 2022/02   2022-02-01
#> 3 22.03     2022-03-01
#> 4 <NA>      NA

Created on 2022-05-16 by the reprex package (v2.0.1)

I've implementing this with the following steps:

  • add "-01" to the end of the strings we're trying to parse, and then
  • use one the supported orders ("ymd" or "myd")

@dragosmg dragosmg marked this pull request as ready for review May 16, 2022 10:27
@dragosmg dragosmg marked this pull request as draft May 16, 2022 10:34
@github-actions
Copy link

@dragosmg dragosmg marked this pull request as ready for review May 16, 2022 14:12
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - chuck in a few explanatory comments and I'll take another look.

@dragosmg dragosmg requested a review from thisisnic May 17, 2022 12:59
Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but would like a second pairs of eyes on this before merging; @jonkeane or @paleolimbot - mind taking a look?

@thisisnic thisisnic requested a review from jonkeane May 17, 2022 16:55
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been following the latest PRs on this front and I think it's very cool what you've been able to do! Just two notes about for() + out[[i] <- something possibly being rewritten using a map()-like expression (but no strong feelings if we do this elsewhere in Arrow and I missed it).

@thisisnic thisisnic closed this in 60f6caf May 18, 2022
@ursabot
Copy link

ursabot commented May 18, 2022

Benchmark runs are scheduled for baseline = 0742f78 and contender = 60f6caf. 60f6caf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️2.06% ⬆️1.48%] test-mac-arm
[Failed ⬇️0.0% ⬆️11.03%] ursa-i9-9960x
[Finished ⬇️1.38% ⬆️0.28%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 60f6caf9 ec2-t3-xlarge-us-east-2
[Failed] 60f6caf9 test-mac-arm
[Failed] 60f6caf9 ursa-i9-9960x
[Finished] 60f6caf9 ursa-thinkcentre-m75q
[Finished] 0742f78a ec2-t3-xlarge-us-east-2
[Failed] 0742f78a test-mac-arm
[Failed] 0742f78a ursa-i9-9960x
[Finished] 0742f78a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 18, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

kou pushed a commit that referenced this pull request Feb 20, 2023
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants