Skip to content

ARROW-16395: [R] Implement lubridate's parsers with year, month, and day, hour, minute, and second components #13627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
paleolimbot merged 3 commits into from
Jul 22, 2022
Merged

ARROW-16395: [R] Implement lubridate's parsers with year, month, and day, hour, minute, and second components #13627

paleolimbot merged 3 commits into from
Jul 22, 2022

Conversation

@rok
Copy link
Member

@rok rok commented Jul 16, 2022

This is to resolve ARROW-16395.

@github-actions
Copy link

github-actions bot commented Jul 16, 2022

https://issues.apache.org/jira/browse/ARROW-16395

@rok rok force-pushed the ARROW-16395 branch 3 times, most recently from 9bd8f11 to 2d68cdf Compare July 19, 2022 11:02
@rok rok marked this pull request as ready for review July 19, 2022 16:45
@rok
Copy link
Member Author

rok commented Jul 19, 2022

@dragosmg is this missing something obvious?

@rok rok requested a review from paleolimbot July 19, 2022 16:45
dragosmg
dragosmg reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@dragosmg dragosmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Many thanks. Just a couple of thoughts.

@rok rok force-pushed the ARROW-16395 branch 2 times, most recently from a4e5059 to e6f0ead Compare July 20, 2022 14:50
dragosmg
dragosmg approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@dragosmg dragosmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rok rok requested a review from jonkeane July 20, 2022 16:22
@rok rok requested a review from nealrichardson July 20, 2022 19:10
@rok
Copy link
Member Author

rok commented Jul 21, 2022

@nealrichardson do you think we could get this into the release?

@dragosmg dragosmg mentioned this pull request Jul 22, 2022
Merged
paleolimbot
paleolimbot approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a local checkout and stepped through these. Looks great!

@paleolimbot paleolimbot merged commit 3c7a0ca into apache:master Jul 22, 2022
@rok
Copy link
Member Author

rok commented Jul 22, 2022

Thanks for reviews and merge @dragosmg & @paleolimbot !

@ursabot
Copy link

ursabot commented Jul 24, 2022

Benchmark runs are scheduled for baseline = 9442e1c and contender = 3c7a0ca. 3c7a0ca is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.21% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.11% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 3c7a0cad ec2-t3-xlarge-us-east-2
[Failed] 3c7a0cad test-mac-arm
[Failed] 3c7a0cad ursa-i9-9960x
[Finished] 3c7a0cad ursa-thinkcentre-m75q
[Failed] 9442e1ce ec2-t3-xlarge-us-east-2
[Failed] 9442e1ce test-mac-arm
[Failed] 9442e1ce ursa-i9-9960x
[Finished] 9442e1ce ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@asfimport asfimport mentioned this pull request Jul 24, 2022
Closed
@eitsupi eitsupi mentioned this pull request Feb 19, 2023
Merged
kou pushed a commit that referenced this pull request Feb 20, 2023
@eitsupi
GH-33631: [R] Rewrite Jira ticket numbers in pkgdown documents to Git…
be40d9f 
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

@jonkeane jonkeane Awaiting requested review from jonkeane

@nealrichardson nealrichardson Awaiting requested review from nealrichardson

+1 more reviewer

@dragosmg dragosmg dragosmg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rok @ursabot @paleolimbot @dragosmg