Skip to content

Conversation

@dragosmg
Copy link
Contributor

@dragosmg dragosmg commented Mar 9, 2022

This PR adds a partial implementation of parse_date_time():

  • only parses the year, month, and date components (no hours, minutes and seconds yet)
  • does not support parsing of strings without separators (e.g. "220912" to 2022-09-12)
  • lubridate::parse_date_time() infers the most likely format given orders (via guess_formats(), while the Arrow binding does not do any inference.

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@dragosmg dragosmg changed the title first pass at implementing fast_strptime() ARROW-14848 [R] Implement bindings for lubridate's parse_date_time, parse_date_time2, and fast_strptime Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@dragosmg
Copy link
Contributor Author

dragosmg commented Apr 1, 2022

There seems to be a registration issue with replace_substring_regex: https://github.com/apache/arrow/runs/5787187215?check_suite_focus=true#step:20:18491

@dragosmg dragosmg marked this pull request as ready for review April 1, 2022 14:44
@dragosmg dragosmg changed the title ARROW-14848 [R] Implement bindings for lubridate's parse_date_time, parse_date_time2, and fast_strptime ARROW-14848: [R] Implement bindings for lubridate's parse_date_time, parse_date_time2, and fast_strptime Apr 28, 2022
@dragosmg
Copy link
Contributor Author

It looks like the arrow replace_substring_regex function (used by the gsub binding) isn't registered for R 3.6 with rtools35 on Windows. Would it be acceptable to skip the offending unit test on R 3.6 on Windows?

@dragosmg
Copy link
Contributor Author

dragosmg commented May 6, 2022

I added a detailed NEWS entry about the current limitations of parse_date_time().

@dragosmg dragosmg marked this pull request as draft May 6, 2022 11:18
@dragosmg dragosmg marked this pull request as ready for review May 6, 2022 11:23
@dragosmg dragosmg marked this pull request as draft May 6, 2022 11:29
@dragosmg dragosmg marked this pull request as ready for review May 6, 2022 11:49
@dragosmg
Copy link
Contributor Author

dragosmg commented May 9, 2022

@jonkeane is there anything else I need to do on this PR?

@dragosmg dragosmg requested a review from jonkeane May 9, 2022 15:07
@dragosmg
Copy link
Contributor Author

dragosmg commented May 9, 2022

@jonkeane is there anything else needed for this PR?

@jonkeane jonkeane closed this in 214135d May 9, 2022
@ursabot
Copy link

ursabot commented May 11, 2022

Benchmark runs are scheduled for baseline = b264dca and contender = 214135d. 214135d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.58% ⬆️0.0%] test-mac-arm
[Finished ⬇️2.5% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.32% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 214135d8 ec2-t3-xlarge-us-east-2
[Finished] 214135d8 test-mac-arm
[Finished] 214135d8 ursa-i9-9960x
[Finished] 214135d8 ursa-thinkcentre-m75q
[Finished] b264dca5 ec2-t3-xlarge-us-east-2
[Finished] b264dca5 test-mac-arm
[Finished] b264dca5 ursa-i9-9960x
[Finished] b264dca5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 11, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

kou pushed a commit that referenced this pull request Feb 20, 2023
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants