Skip to content

Conversation

@nealrichardson
Copy link
Member

Note that there is no test in the test suite that asserts that ~ is expanded correctly because we can only write to tempfiles in the tests, but It Works on My Machine ™️ .

cc @romainfrancois

@nealrichardson
Copy link
Member Author

Debugging the windows build failure, stand by

@codecov-io
Copy link

Codecov Report

Merging #5169 into master will decrease coverage by 12.41%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5169       +/-   ##
===========================================
- Coverage   87.63%   75.22%   -12.42%     
===========================================
  Files        1022       57      -965     
  Lines      146258     3604   -142654     
  Branches     1437        0     -1437     
===========================================
- Hits       128174     2711   -125463     
+ Misses      17722      893    -16829     
+ Partials      362        0      -362
Impacted Files Coverage Δ
r/R/feather.R 63.41% <ø> (-1.71%) ⬇️
r/R/csv.R 97.22% <ø> (-0.15%) ⬇️
r/R/RecordBatchWriter.R 72.22% <ø> (+2.22%) ⬆️
r/R/json.R 90% <ø> (-1.31%) ⬇️
r/R/read_table.R 100% <ø> (ø) ⬆️
r/R/write_arrow.R 96.42% <ø> (-0.13%) ⬇️
r/R/compression.R 90.9% <ø> (-1.4%) ⬇️
r/R/RecordBatchReader.R 70.58% <ø> (-1.64%) ⬇️
r/R/parquet.R 73.07% <100%> (ø) ⬆️
r/R/io.R 74.28% <75%> (ø) ⬆️
... and 965 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9236d...635d954. Read the comment docs.

@fsaintjacques
Copy link
Contributor

Is it expected from R libraries to expand path? If so, I have no objection to merge this.

@nealrichardson
Copy link
Member Author

Yes:

> write.csv(iris, file="~/Downloads/iris.csv")
> read.csv("~/Downloads/iris.csv")
      X Sepal.Length Sepal.Width Petal.Length Petal.Width    Species
1     1          5.1         3.5          1.4         0.2     setosa
2     2          4.9         3.0          1.4         0.2     setosa
3     3          4.7         3.2          1.3         0.2     setosa
4     4          4.6         3.1          1.5         0.2     setosa
5     5          5.0         3.6          1.4         0.2     setosa
6     6          5.4         3.9          1.7         0.4     setosa
...

@pitrou pitrou closed this in 6a7f07a Aug 27, 2019
kou pushed a commit that referenced this pull request Feb 20, 2023
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants