Skip to content

Conversation

@hadley
Copy link
Contributor

@hadley hadley commented Nov 3, 2022

The recycling rules in map2() are now stricter, so we need to check that x actually has columns before applying the metadata.

I also mildly refactored the test to make it easier to run in isolation; I'm happy to revert those changes if desired.

The recycling rules in map2() are now stricter, so we need to check that `x` actually has columns before applying the metadata.

I also mildly refactored the test to make it easier to run in isolation; I'm happy to revert those changes if desired.
@nealrichardson nealrichardson changed the title Fix for dev purrr MINOR: [R] Fix for dev purrr Nov 3, 2022
Copy link
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nealrichardson nealrichardson merged commit 04917f9 into apache:master Nov 3, 2022
@ursabot
Copy link

ursabot commented Nov 3, 2022

Benchmark runs are scheduled for baseline = 8074496 and contender = 04917f9. 04917f9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.91% ⬆️1.68%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.14% ⬆️0.11%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 04917f94 ec2-t3-xlarge-us-east-2
[Finished] 04917f94 test-mac-arm
[Finished] 04917f94 ursa-i9-9960x
[Finished] 04917f94 ursa-thinkcentre-m75q
[Finished] 8074496c ec2-t3-xlarge-us-east-2
[Finished] 8074496c test-mac-arm
[Finished] 8074496c ursa-i9-9960x
[Finished] 8074496c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Nov 3, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

@nealrichardson nealrichardson changed the title MINOR: [R] Fix for dev purrr ARROW-18305: [R] Fix for dev purrr Nov 10, 2022
@github-actions
Copy link

kou pushed a commit that referenced this pull request Nov 15, 2022
The recycling rules in map2() are now stricter, so we need to check that `x` actually has columns before applying the metadata.

I also mildly refactored the test to make it easier to run in isolation; I'm happy to revert those changes if desired.

Authored-by: Hadley Wickham <[email protected]>
Signed-off-by: Neal Richardson <[email protected]>
kou pushed a commit that referenced this pull request Feb 20, 2023
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants