ARROW-6364: [R] Handling unexpected input to time64() et al: #5201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5201 +/- ##
===========================================
- Coverage 88.69% 75.47% -13.22%
===========================================
Files 934 57 -877
Lines 121092 3649 -117443
Branches 1437 0 -1437
===========================================
- Hits 107399 2754 -104645
+ Misses 13331 895 -12436
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
Member
|
@nealrichardson You'll need to rebase and fix conflicts. |
nealrichardson
force-pushed
the
time-unit-validation
branch
from
87209fb to
74645cd
Compare
Member
Author
|
Rebased |
pitrou
reviewed
Aug 27, 2019
| # Allow non-integer input for convenience | ||
| unit <- as.integer(unit) | ||
| } else { | ||
| stop('"unit" should be one of ', oxford_paste(names(valid_units), "or"), call.=FALSE) |
Member
There was a problem hiding this comment.
Is there a non-Oxford paste? :-)
Member
Author
There was a problem hiding this comment.
Not for me ;)
(paste() is the vectorized R string concatenation function)
Member
pitrou
approved these changes
Aug 27, 2019
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1. Trusting @nealrichardson on this.
kou
pushed a commit
that referenced
this pull request
Feb 20, 2023
…Hub issue numbers (#34260) Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature. Issue numbers have been rewritten based on the following correspondence. Also, the pkgdown settings have been changed and updated to link to GitHub. I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly. --- ARROW-6338 #5198 ARROW-6364 #5201 ARROW-6323 #5169 ARROW-6278 #5141 ARROW-6360 #5329 ARROW-6533 #5450 ARROW-6348 #5223 ARROW-6337 #5399 ARROW-10850 #9128 ARROW-10624 #9092 ARROW-10386 #8549 ARROW-6994 #23308 ARROW-12774 #10320 ARROW-12670 #10287 ARROW-16828 #13484 ARROW-14989 #13482 ARROW-16977 #13514 ARROW-13404 #10999 ARROW-16887 #13601 ARROW-15906 #13206 ARROW-15280 #13171 ARROW-16144 #13183 ARROW-16511 #13105 ARROW-16085 #13088 ARROW-16715 #13555 ARROW-16268 #13550 ARROW-16700 #13518 ARROW-16807 #13583 ARROW-16871 #13517 ARROW-16415 #13190 ARROW-14821 #12154 ARROW-16439 #13174 ARROW-16394 #13118 ARROW-16516 #13163 ARROW-16395 #13627 ARROW-14848 #12589 ARROW-16407 #13196 ARROW-16653 #13506 ARROW-14575 #13160 ARROW-15271 #13170 ARROW-16703 #13650 ARROW-16444 #13397 ARROW-15016 #13541 ARROW-16776 #13563 ARROW-15622 #13090 ARROW-18131 #14484 ARROW-18305 #14581 ARROW-18285 #14615 * Closes: #33631 Authored-by: SHIMA Tatsuya <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #5198 (ARROW-6338) and is just one commit beyond that patch: 87209fb