tools: clarify README linter error message #59160
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
reviewed
Jul 22, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Jul 24, 2025
joyeecheung
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/59160 ✔ Done loading data for nodejs/node/pull/59160 ----------------------------------- PR info ------------------------------------ Title tools: clarify README linter error message (#59160) Author Joyee Cheung <[email protected]> (@joyeecheung) Branch joyeecheung:lint-readme-message -> nodejs:main Labels tools, commit-queue-squash Commits 2 - tools: clarify README linter error message - fixup! tools: clarify README linter error message Committers 2 - Joyee Cheung <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/59160 Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59160 Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 22 Jul 2025 09:05:28 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/59160#pullrequestreview-3050396874 ✘ This PR needs to wait 90 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16524945708 |
richardlau
approved these changes
Jul 25, 2025
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 7d6ce77 |
aduh95
pushed a commit
that referenced
this pull request
Jul 25, 2025
PR-URL: #59160 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some confusion when landing #59157 when the handle and the link doesn't match and the error message wasn't very clear about what's going on.