repl: fix repl crashing on variable declarations without init #59032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
This is significantly impacting REPL (I'm really sorry about that 😓), so I am proposing to fast-track hoping to land this fix as soon as possible |
dario-piotrowicz
added
the
fast-track
|
Fast-track has been requested by @dario-piotrowicz. Please 👍 to approve. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59032 +/- ##
==========================================
- Coverage 90.08% 90.06% -0.03%
==========================================
Files 645 645
Lines 189128 189132 +4
Branches 37088 37099 +11
==========================================
- Hits 170378 170338 -40
- Misses 11470 11512 +42
- Partials 7280 7282 +2
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Jul 11, 2025
KhafraDev
approved these changes
Jul 11, 2025
jasnell
approved these changes
Jul 11, 2025
jasnell
added
the
commit-queue
|
@nodejs/releasers ... this should likely go out in a patch release fairly soon |
nodejs-github-bot
removed
the
commit-queue
|
Landed in 049664b |
targos
pushed a commit
that referenced
this pull request
Jul 17, 2025
PR-URL: #59032 Fixes: #59029 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #59029