src,test: fix config file parsing for flags defaulted to true #59110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
geeksilva97
force-pushed
the
fix-config-file-parsing-for-boolean
branch
from
50c110b to
377dcb3
Compare
geeksilva97
force-pushed
the
fix-config-file-parsing-for-boolean
branch
from
ce7ca6f to
99ef802
Compare
geeksilva97
changed the title
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/16362374774 |
marco-ippolito
removed
the
request-ci-failed
pmarchini
approved these changes
Jul 18, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59110 +/- ##
==========================================
- Coverage 90.05% 90.05% -0.01%
==========================================
Files 645 645
Lines 189153 189155 +2
Branches 37093 37100 +7
==========================================
- Hits 170339 170338 -1
- Misses 11518 11523 +5
+ Partials 7296 7294 -2
🚀 New features to boost your workflow:
|
marco-ippolito
approved these changes
Jul 18, 2025
pmarchini
approved these changes
Jul 18, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
geeksilva97
added
the
author ready
geeksilva97
added
commit-queue
lpinca
approved these changes
Jul 18, 2025
pmarchini
reviewed
Jul 19, 2025
Comment on lines
+63
to
+65
| test('should parse boolean flag defaulted to true', async () => { | ||
| const result = await spawnPromisified(process.execPath, [ | ||
| '--experimental-config-file', |
There was a problem hiding this comment.
Very minor nit: we can also expose internals in order to directly verify the value of the option that we're setting. This might help decouple the option behaviour from the test. In this case, we're using the behaviour of process.emitWarning to validate that --no-warnings has been correctly managed.
targos
approved these changes
Jul 19, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in ab694d5 |
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #59110 Reviewed-By: Pietro Marchini <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58929
This PR fixes config file parsing for boolean options that are enabled by default.
In my last PR, I did a quick fix for boolean values. Such a fix missed the case where the flag is
trueby default, as--warnings. To ensure we're disabling a flag, we have to output that flag prefixed with--no-.